814102 - Make the object used for 'this' when compartment sharing a FakeBackstagePass.

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

This tricks promises into working.

https://groups.google.com/d/msg/mozilla.dev.platform/Ic2YmqbRyIE/wsrbyWiuqXoJ

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 684115 [details] [diff] [review]
Patch

Review of attachment 684115 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/loader/mozJSComponentLoader.cpp
@@ +73,5 @@
>  using namespace xpc;
>  
> +static JSClass kFakeBackstagePassJSClass =
> +{
> +    "FakeBackstagePass",

Please add a comment here in the code for why we need to do this. Otherwise, someone is sure to come along and ask why we're not simply using an Object.

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a0b129e5ee0e

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Please post changeset links and set the appropriate status flags when uplifting.
https://hg.mozilla.org/releases/mozilla-aurora/rev/2923c817adf8

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/releases/mozilla-beta/rev/69d882c756b2