814104 - Create the loadSubScript function in the right compartment

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

The loadSubScript function in dbg-server.jsm is imported into a sandbox and then executed to load subscripts.  Importing functions totally confuses our compartment sharing stuff we have for b2g, so those subscripts are ending up being run in the JSM scope instead of in the sandbox.  The attached patch creates the function in the sandbox so it's associated with the right scope and good things happen.

robcee, please redirect the review if you can't review this.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Can you use function.toSource() instead?

Comment 2

[Masatoshi Kimura [:emk]]

function.toSource() is our extension. Standard function.toString() would be preferred.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/532c363394cb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please post changeset links and set the appropriate status flags when uplifting.
https://hg.mozilla.org/releases/mozilla-aurora/rev/444a70f88360

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d1012a0350cb