Closed Bug 814104 Opened 8 years ago Closed 8 years ago

Create the loadSubScript function in the right compartment

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(firefox18 fixed, firefox19 fixed, firefox20 fixed)

RESOLVED FIXED
Firefox 20
Tracking Status
firefox18 --- fixed
firefox19 --- fixed
firefox20 --- fixed

People

(Reporter: khuey, Assigned: khuey)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
The loadSubScript function in dbg-server.jsm is imported into a sandbox and then executed to load subscripts.  Importing functions totally confuses our compartment sharing stuff we have for b2g, so those subscripts are ending up being run in the JSM scope instead of in the sandbox.  The attached patch creates the function in the sandbox so it's associated with the right scope and good things happen.

robcee, please redirect the review if you can't review this.
Attachment #684116 - Flags: review?(rcampbell)
Attachment #684116 - Flags: review?(rcampbell) → review+
Can you use function.toSource() instead?
function.toSource() is our extension. Standard function.toString() would be preferred.
https://hg.mozilla.org/mozilla-central/rev/532c363394cb
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Please post changeset links and set the appropriate status flags when uplifting.
https://hg.mozilla.org/releases/mozilla-aurora/rev/444a70f88360
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.