Closed
Bug 814139
Opened 13 years ago
Closed 13 years ago
Script timeout gets lost when switching to OOP frame
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox18 fixed, firefox19 fixed, firefox20 fixed)
RESOLVED
FIXED
mozilla20
People
(Reporter: jgriffin, Assigned: jgriffin)
References
Details
Attachments
(2 files)
985 bytes,
text/plain
|
Details | |
2.36 KB,
patch
|
mdas
:
review+
|
Details | Diff | Splinter Review |
When switching to an OOP frame, the script and search timeouts are getting lost, because the instance of the frame script running in the OOP frame has no knowledge of how these were set.
When switching frames, we should always send the current script/search timeouts to it.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → jgriffin
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
This passes the attached test. That test requires Gaia so I won't check it into m-c; we could consider adding it to gaia-ui-tests after this lands, however.
Attachment #684245 -
Flags: review?(mdas)
Comment 3•13 years ago
|
||
(In reply to Jonathan Griffin (:jgriffin) from comment #0)
> When switching to an OOP frame, the script and search timeouts are getting
> lost, because the instance of the frame script running in the OOP frame has
> no knowledge of how these were set.
>
> When switching frames, we should always send the current script/search
> timeouts to it.
Ah, of course! that makes a lot of sense now.
Updated•13 years ago
|
Attachment #684245 -
Flags: review?(mdas) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Whiteboard: [automation-needed-in-aurora][automation-needed-in-beta]
Target Milestone: --- → mozilla20
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 6•13 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2ecb7ca81077
https://hg.mozilla.org/releases/mozilla-beta/rev/3540f4d72972
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
status-firefox20:
--- → fixed
Whiteboard: [automation-needed-in-aurora][automation-needed-in-beta]
Updated•3 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•