nsMovemailService doesn't build with external linkage anymore

RESOLVED FIXED in Thunderbird 20.0

Status

MailNews Core
Movemail
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Karsten Düsterloh, Assigned: Karsten Düsterloh)

Tracking

({regression})

unspecified
Thunderbird 20.0
x86_64
Linux
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 684213 [details] [diff] [review]
include missing header

Building with --enable-incomplete-external-linkage now fails:

In file included from /home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/local/src/nsMovemailService.cpp:18:0:
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/local/src/nsMovemailService.h:31:3: error: ‘nsCOMPtr’ does not name a type
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/local/src/nsMovemailService.cpp: In member function ‘void nsMovemailService::Error(int32_t, const PRUnichar**, uint32_t)’:
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/local/src/nsMovemailService.cpp:101:8: error: ‘mMsgWindow’ was not declared in this scope
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/local/src/nsMovemailService.cpp:104:17: error: ‘mMsgWindow’ was not declared in this scope
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/local/src/nsMovemailService.cpp: In member function ‘virtual nsresult nsMovemailService::GetNewMail(nsIMsgWindow*, nsIUrlListener*, nsIMsgFolder*, nsIMovemailIncomingServer*, nsIURI**)’:
/home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/local/src/nsMovemailService.cpp:360:3: error: ‘mMsgWindow’ was not declared in this scope
make[2]: *** [nsMovemailService.o] Error 1
Attachment #684213 - Flags: review?(neil)
(Assignee)

Updated

5 years ago
Assignee: nobody → mnyromyr

Comment 1

5 years ago
(In reply to Karsten Düsterloh from comment #0)
> /home/kd/projects/mozilla/mozilla.org/src/trunk/mailnews/local/src/
> nsMovemailService.h:31:3: error: ‘nsCOMPtr’ does not name a type
Since the error is in the .h file, why did you patch the .cpp file?
(Assignee)

Comment 2

5 years ago
(In reply to neil@parkwaycc.co.uk from comment #1)
> Since the error is in the .h file, why did you patch the .cpp file?

Huh? But I didn't!?!

Comment 3

5 years ago
Comment on attachment 684213 [details] [diff] [review]
include missing header

Oops, engage brain before typing...
Attachment #684213 - Flags: review?(neil) → review+
(Assignee)

Updated

5 years ago
Attachment #684213 - Flags: superreview?(mbanner)
Comment on attachment 684213 [details] [diff] [review]
include missing header

This doesn't need sr.
Attachment #684213 - Flags: superreview?(mbanner)
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/comm-central/rev/44d69d59d729
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
You need to log in before you can comment on or make changes to this bug.