814233 - Thread pool landing busts JS shell builds if configured without NSPR

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Shu-yu Guo [:shu]]

The files should be guarded by JS_THREADSAFE.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: unbust

Comment 2

[David Mandelin [:dmandelin]]

Comment on attachment 684221 [details] [diff] [review]
unbust

Review of attachment 684221 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, the dreaded NSPR.

Comment 3

[Niko Matsakis [:nmatsakis]]

Sadly I think that this patch broke the build when Shu pushed it to the try server.

Comment 4

[Niko Matsakis [:nmatsakis]]

Attachment: Make things build without NSPR.

try build is pending

Comment 5

[Niko Matsakis [:nmatsakis]]

Try build for previous patch: https://tbpl.mozilla.org/?tree=Try&rev=7c5820bb9282

Comment 6

[Niko Matsakis [:nmatsakis]]

Try build is green.

Comment 7

[Brian Hackett [Laid off!]]

Comment on attachment 684261 [details] [diff] [review]
Make things build without NSPR.

Review of attachment 684261 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing.  dmandelin is I think on PTO.

Comment 8

[Niko Matsakis [:nmatsakis]]

Adding checkin-needed to keywords (I don't have perm. to push currently)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a765d833483a

Niko, I'm not sure how you generated this patch, but can you please make sure that you've got hg configured per the guidelines below? The metadata wasn't in a format that hg recognized. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in

Comment 10

[Niko Matsakis [:nmatsakis]]

OK---I double checked and I have setup my hgrc as described in that link.  I generated the patch by uploading the file directly from .hg/patches.  Perhaps I should do |hg export qtip| instead; or perhaps my copy of hg is just outdated.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a765d833483a

Comment 12

[Mozilla RelEng Bot]

Try run for 7c5820bb9282 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7c5820bb9282
Results (out of 309 total builds):
    success: 290
    warnings: 16
    failure: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-7c5820bb9282