814302 - don't print to the console when an invalid selector is passed to mozMatchesSelector, etc.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When mozMatchesSelector and friends are passed a syntactically-invalid selector, we print to the console due to an NS_ENSURE_SUCCESS.  Since this happens quite a bit (e.g., jQuery animations passing ":hidden" quite frequently), it would be better if this weren't console-spam.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Don't print to console when an invalid selector is passed to mozMatchesSelector.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 684303 [details] [diff] [review]
Don't print to console when an invalid selector is passed to mozMatchesSelector.

r=me

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1926fc1f9f3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a1926fc1f9f3

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: , part 2: Don't print to console when an invalid selector is passed to querySelector*.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 693260 [details] [diff] [review]
, part 2: Don't print to console when an invalid selector is passed to querySelector*.

r=me

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

part 2 landed: https://hg.mozilla.org/mozilla-central/rev/f6550d0960c8