814308 - MediaDecoder::SetDuration doesn't handle aDuration=inf correctly

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

For example, if a clone is created via InitializeDecoderAsClone, MediaDecoder::GetDuration() may return inf, a double >= 0, or NaN.  This value is then passed to the clone's MediaDecoder::SetDuration, which assumes aDuration is >= 0 and static casts the value to int64_t.

Comment 1

[Paul Adenot (:padenot)]

Attachment: MediaDecoder::SetDuration doesn't handle aDuration=inf correctly. r=

I used |mfbt/FloatingPoint.h| header because |std::isnan| and familly is apparently
not available on Windows.

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 695801 [details] [diff] [review]
MediaDecoder::SetDuration doesn't handle aDuration=inf correctly.  r=

+  } else if (MOZ_DOUBLE_IS_NaN(aDuration)) {
+    mDuration = -1;

Do we need to SetInfinite(true) here, too? MetadataLoaded treats a duration of -1 from the state machine as infinite.

Comment 3

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/23456fc21052

Comment 4

[Ed Morley [:emorley]]

Push backed out for Windows pgo-only mochitest-1 timeouts in media tests, since the backout of just 1abf4c88f8f1 didn't work (see bug 793274 comment 12 for example logs):
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2912b7e727a

Comment 5

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea7f8d86e592

I bisected the queue on try, this patch is safe.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ea7f8d86e592