814334 - [Traceback] TypeError: %d format: a number is required, not NoneType on firstrun page

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Anthony Ricaud (:rik)]

With 'HTTP_USER_AGENT': 'Mozilla/5.0 (SaferSurf) Firefox 1.5'

Traceback (most recent call last):

 File "/data/www/www.mozilla.org-django/bedrock/vendor/lib/python/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/www/www.mozilla.org-django/bedrock/vendor/lib/python/django/views/decorators/vary.py", line 22, in inner_func
   response = func(*args, **kwargs)

 File "/data/www/www.mozilla.org-django/bedrock/apps/firefox/views.py", line 86, in latest_fx_redirect
   if not is_current_or_newer(user_version):

 File "/data/www/www.mozilla.org-django/bedrock/apps/firefox/views.py", line 115, in is_current_or_newer
   user_int = int('%d%02d' % (user.major, user.minor1))

TypeError: %d format: a number is required, not NoneType

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/b8cd939c7e4c5717d48d8072dca297fcbf61b3d0
There are all sorts of user agents out there

fix bug 814334

Comment 2

[Anthony Ricaud (:rik)]

This has been pushed to production.