Closed
Bug 814419
Opened 12 years ago
Closed 12 years ago
BaselineCompiler: Support int32 in ToBool IC
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
3.68 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
We need this for SS bitops-bits-in-byte:
if (b & m) c++;
When we see a less common input type we should probably just attach a generic stub that handles every type. Since int32 is common, it seems useful to handle it separately so that we can collect good type information.
Attachment #684417 -
Flags: review?(kvijayan)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 684417 [details] [diff] [review]
Patch
Review of attachment 684417 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Agreed about ICs for ToBool. We may want to add a string stub in there eventually.
Attachment #684417 -
Flags: review?(kvijayan) → review+
I don't have data to proof it, but I guess undefined/null are kind of common, too.
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•