Closed Bug 814510 Opened 7 years ago Closed 7 years ago

Downloads Summary icon needs to be revisited

Categories

(Firefox :: Downloads Panel, defect, P2)

x86
All
defect

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: mconley, Assigned: mconley)

References

Details

(Keywords: icon)

Attachments

(8 files, 1 obsolete file)

The icon displayed on the left side of the Downloads Summary is being taken toolkit/themes/*stripe/mozapps/downloads/.

We might want to move those to browser/themes/*stripe/downloads

We also need to create a scaled up version for Retina displays on pinstripe.

We also need to replace, or resize the ones being used on winstripe - the current ones are 24x24, being scaled up to 32x32, which makes them look fuzzy.
Looks like shorlander just won another bug
Assignee: nobody → shorlander
(In reply to Mike Conley (:mconley) from comment #0)
> We might want to move those to browser/themes/*stripe/downloads

Well, if it's being used by toolkit code I don't think we want to move it, we may want to provide a different icon for browser.
mxr link to the icon?
(In reply to Marco Bonardo [:mak] from comment #2)
> (In reply to Mike Conley (:mconley) from comment #0)
> > We might want to move those to browser/themes/*stripe/downloads
> 
> Well, if it's being used by toolkit code I don't think we want to move it,
> we may want to provide a different icon for browser.

Er, yes - sorry, that's what I meant. I wasn't clear.

> mxr link to the icon?

gnomestripe: https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/gnomestripe/mozapps/downloads/downloadIcon.png

pinstripe: https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/mozapps/downloads/downloadIcon.png

winstripe - classic: https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/mozapps/downloads/downloadIcon.png

winstripe - aero: https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/mozapps/downloads/downloadIcon-aero.png
It could also be modernized and unified on various platforms.
Flags: needinfo?(shorlander)
Gentle UX-ping, we are still waiting for the new icon.
I think the icon that will be used can be seen on this mockup, but I'm not sure : http://cl.ly/image/1o0J1K2J3T0V
Priority: -- → P2
Attached patch Patch v1 (obsolete) — Splinter Review
Assignee: shorlander → mconley
Attached patch Patch v1.1Splinter Review
Removing unneeded size constraints on the icon in winstripe.
Attachment #694947 - Attachment is obsolete: true
Comment on attachment 694960 [details] [diff] [review]
Patch v1.1

Review of attachment 694960 [details] [diff] [review]:
-----------------------------------------------------------------

It looks a bit too large in Aero... though I suppose Stephen verified that, in case we can replace the icon easily at any time, let's pave the way.
Attachment #694960 - Flags: review?(mak77) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/acb02d013052

Mike, can you make sure that you've got hg configured to generate proper patch metadata in the future? It makes life easier when you need someone else to checkin a patch for you.
Keywords: checkin-needed
(In reply to Ryan VanderMeulen [Intermittent Availability Until Jan. 2] from comment #17)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/acb02d013052
> 
> Mike, can you make sure that you've got hg configured to generate proper
> patch metadata in the future? It makes life easier when you need someone
> else to checkin a patch for you.

Ack - sorry about that. Was away from my development machine. My apologies.
https://hg.mozilla.org/mozilla-central/rev/acb02d013052
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.