814530 - make @supports automatically be disabled by default on Release and Beta

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

I think it would be good for the pref controlling whether @supports is enabled to have a third state (the default) which means "false in Release, Beta or ESR, true otherwise".  Here's a patch that does that.  WDYT?  If it's a good approach maybe we can apply it to the other experimental features behind prefs.

I check both boolean and int values because some people may have already explicitly set the pref to true in their profiles.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 684532 [details] [diff] [review]
patch

I'd rather do this sort of thing at build-time rather than run-time.

I'm also not sure it'll do the right thing for things like Linux-distro builds.

Comment 2

[Cameron McCormack (:heycam)]

OK, we can do it with some preprocessing on all.js then.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: patch v2

This uses the new macro available from bug 820148.

Comment 4

[Cameron McCormack (:heycam)]

tracking? to make sure we do this in time for the next uplift.

Comment 5

[Alex Keybl [:akeybl]]

(In reply to Cameron McCormack (:heycam) from comment #4)
> tracking? to make sure we do this in time for the next uplift.

We just approved bug 820148. Please make sure to put a reminder on your calendar as opposed to waiting for a ping from us :)

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 693645 [details] [diff] [review]
patch v2

r=dbaron

Though I admit to not understanding how the addition to PREF_PPFLAGS in build/Makefile.in in https://hg.mozilla.org/mozilla-central/rev/7286dac15291 affects the preprocessing of all.js...

Comment 7

[Cameron McCormack (:heycam)]

PREF_PPFLAGS is used here: https://hg.mozilla.org/mozilla-central/file/tip/modules/libpref/src/Makefile.in#l54

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 693645 [details] [diff] [review]
patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: feature will be enabled on Beta too soon
Testing completed (on m-c, etc.): none, just a pref change that we've done before
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: N/A

Comment 9

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c8ab97bf848

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Cameron McCormack (:heycam) from comment #7)
> PREF_PPFLAGS is used here:
> https://hg.mozilla.org/mozilla-central/file/tip/modules/libpref/src/Makefile.
> in#l54

Yeah, but I don't see why setting something in build/Makefile.in would have any effects beyond build/Makefile.in (as opposed to doing something in config.mk or rules.mk, which gets included in every makefile).

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(If you've tested that it works, I'll believe you, but I'm suspicious.)

Comment 12

[Cameron McCormack (:heycam)]

I had tested this, but I am double checking now.

Comment 13

[Cameron McCormack (:heycam)]

You are right, it doesn't work.  I must have switched makefile and not re-tested properly.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

ok, probably best to continue this discussion in bug 820148.

Comment 15

[Cameron McCormack (:heycam)]

Bug 820148 landed again.

Comment 16

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/1c8ab97bf848

Comment 17

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4a251b94509f