814531 - Enable WebRTC crashtests on mozilla-central

Status: RESOLVED DUPLICATE of bug 826044

(Core :: WebRTC, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

We want to enable the crashtests on mozilla-central. But before we can do that we have to fix the remaining memory leaks and the assertion for mozRTCPeerConnection in IPC mode. See the dependent bugs.

Comment 1

[Jason Smith [:jsmith]]

This probably doesn't make sense to have as a meta bug actually given that there would be a patch here to pref on crashtests.

The leak dependencies are fixed now. What's left to do here in order to pref these on in central with leak checking?

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

-> henrik

I think we're ready to try enabling crashtests

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

I pushed this to try with leak checking enabled for webrtc crashtests:
https://tbpl.mozilla.org/?tree=Try&rev=1bd6312b7f38

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Try server results are all green. I'm going to upload a patch in a minute to enable crashtests by default on m-c.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Attachment: Patch v1

Please keep in mind that when this lands we will have to backout the patch on bug 801682 first before the next merge to Alder.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 697001 [details] [diff] [review]
Patch v1

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5fee86dec9e

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

We have lots of leaks with this push. We should figure out what's wrong with those. I will investigate soon. For now I have backed out the patch:

ssh://hg.mozilla.org/integration/mozilla-inbound/

Comment 8

[Ed Morley [:emorley]]

Backed out for leaks:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=a5fee86dec9e

https://hg.mozilla.org/integration/mozilla-inbound/rev/4f5a049ce9c9

Your try run seems to have alder csets in it, which is perhaps why it was green.

Comment 9

[Maire Reavy [:mreavy]]

Any remaining issues are marked as dependencies on Bug 826044