Closed
Bug 814657
Opened 12 years ago
Closed 12 years ago
[Settings] "show password" is not correct
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P1)
Tracking
(b2g18 verified)
VERIFIED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g18 | --- | verified |
People
(Reporter: sergiov, Assigned: pivanov)
Details
(Keywords: perf, Whiteboard: visual design, UX-P1, uxbranch, landed in uxbranch, BerlinWW)
Attachments
(3 files, 1 obsolete file)
|
248.88 KB,
image/jpeg
|
Details | |
|
181 bytes,
text/html
|
vingtetun
:
review+
vingtetun
:
approval-gaia-v1+
|
Details |
|
33.21 KB,
image/png
|
Details |
Settings - "Show Password" checkbox
- The checkbox used is not correct. - The distance between the input area and the "Show Password" checkbox should be larger so it's possible to easily click both. - The responsiveness of the keyboard is not correct. The keyboard should show up quicker when the user clicks inside the input area.
Very frustrating to the user Need to make sure you can easily either click the check box to turn on show password without clashing with the input box.
|
||
Updated•12 years ago
|
blocking-basecamp: --- → ?
Whiteboard: visual design → visual design UX-P1
|
|
||
Updated•12 years ago
|
blocking-basecamp: ? → ---
|
||
Updated•12 years ago
|
Whiteboard: visual design UX-P1 → visual design, UX-P1, uxbranch
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → pivanov
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: visual design, UX-P1, uxbranch → visual design, UX-P1, uxbranch, landed in uxbranch
|
||
Comment 3•12 years ago
|
||
Now Landed in UX Branch https://github.com/gordonbrander/gaia/commit/1ff8f64929d36b3ebd28e8b700aea4697027cfd0
|
|
Assignee | |
Updated•12 years ago
|
Attachment #698706 -
Flags: review?(sjochimek)
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: visual design, UX-P1, uxbranch, landed in uxbranch → visual design, UX-P1, uxbranch, landed in uxbranch, BerlinWW
|
|
Assignee | |
Comment 4•12 years ago
|
||
NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed: Risk to taking this patch (and alternatives if risky):
Attachment #700431 -
Flags: approval-gaia-master?(21)
Question : shouldn't the hidden network password be fixed as well?
Also what do we do about wifi sharing? Shouldn't we have a hidden option as well for that?
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
Assignee | |
Comment 7•12 years ago
|
||
I will fix this right now. Thanks for the feedback. (In reply to Naoki Hirata :nhirata from comment #5) > Created attachment 700456 [details] > screenshot 1 > > Question : shouldn't the hidden network password be fixed as well?
|
|
Assignee | |
Updated•12 years ago
|
Attachment #698706 -
Attachment is obsolete: true
Attachment #698706 -
Flags: review?(sjochimek)
|
|
Assignee | |
Comment 8•12 years ago
|
||
I just update my PR and now we have the correct "show password" checkbox to "Join hidden network". Thanks Naoki :)
Attachment #700431 -
Flags: review+
Attachment #700431 -
Flags: approval-gaia-master?(21)
Attachment #700431 -
Flags: approval-gaia-master+
|
||
Comment 9•12 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/5ec67324473b84f9f048fe295a8d12f799164db6
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Master build : 2013-03-25-03-07-06 "mozilla-central" revision="bef19bca23f9" "integration/gaia-central" revision="8c401e09a6a9" "gecko.git"revision="bbaac6bbbf5084ef1a3e178ced676ea77db8b24b" "gaia.git" revision="a1259a6c80629daa458428d6a96403841aaab0f0" Gecko http://hg.mozilla.org/releases/mozilla-b2g18/rev/dec694d585e1 Gaia 5a31a56b96a8fc559232d35dabf20411b9c2ca1d BuildID 20130325070203 Version 18.0 Unagi
Status: RESOLVED → VERIFIED
status-b2g18:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•