814689 - Typing is not working for full flash sites

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Plugins, defect)

Description

[Cristian Nicolae (:xti)]

Firefox 20.0a1 (2012-11-23)
Device: Galaxy S2
OS: Android 4.0.3

Steps to reproduce:
1. Go to Settings > Plugins and set it to Enable
2. Go to http://www.zasmakujelegancji.pl/
3. Tap on any date fields and type any date

Expected result:
Typing is working fine on step 3.

Actual result:
No numbers can be filled in the date fields at step 3.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Only use key events for plugins (v1)

Since plugins only accept key events and not other IME events, this patch makes IMEs send key events when a plugin has the keyboard. It does this by using TYPE_NULL as the input type, and by switching to using BaseInputConnection which sends key events for us.

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 694111 [details] [diff] [review]
Only use key events for plugins (v1)

Review of attachment 694111 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

This had been landed in mozilla-inbound as:

http://hg.mozilla.org/integration/mozilla-inbound/rev/d6c5a0ec5757

then on to m-c in:

https://hg.mozilla.org/mozilla-central/rev/d6c5a0ec5757

Comment 4

[Ioana Chiorean]

Firefox 20.0a1 (2013-01-03)
Device: Galaxy Nexus 
OS: Android 4.1.1 

I am able to enter numbers in all 3 data fields from http://www.zasmakujelegancji.pl 
Marking bug as Verified Fixed.