8147 - Boxes display incorrectly when style set to display:none

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[hangas]

In the Address Book window the card view pane (lower right pane) displays
incorrectly when calling setAttribute("style", "display:none") on a box
containing the card view.  It displays what appears to be the top of the window
in this lower pane.

Comment 1

[Eric Vaughan]

This works for me. The following example creates a box with 2 buttons called
"hideit". It then creates 2 other buttons called "hide" and "show" that set the
"hideit" box's display to either none or block. As you will set the box appears
and disappears.

<?xml version="1.0"?>
<?xml-stylesheet href="xul.css" type="text/css"?>
<?xml-stylesheet href="navigator.css" type="text/css"?>

<!DOCTYPE window>

<window style="width: 100%; height: 100%"
xmlns:html="http://www.w3.org/TR/REC-html40"
        xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
        onConstruction="Startup()">

<html:script>
   function hide()
   {
      document.getElementById("tohide").setAttribute("style","display:none");
	  dumb("hidden");
   }
   function show()
   {
      document.getElementById("tohide").setAttribute("style","display:inline");
	  dumb("hidden");
   }
</html:script>

<box align="horizontal">
      <box id="tohide" align="vertical">
		<titledbutton src="resource:/res/toolbar/TB_Forward.gif"
align="bottom" value="Button1"/>
		<titledbutton src="resource:/res/toolbar/TB_Forward.gif"
align="bottom" value="Button2"/>
      </box>

      <titledbutton src="resource:/res/toolbar/TB_Forward.gif" align="bottom"
value="Hide" onclick="hide()"/>
      <titledbutton src="resource:/res/toolbar/TB_Forward.gif" align="bottom"
value="Show" onclick="show()"/>
</box>

</window>

Comment 2

[hangas]

I tried this simple case listed by evaughan, and it works for me too.  My
original case still fails in a big way.  I will attach a file that should be used
to replace the addressbook.js file in the mozilla/mailnews/addrbook/resources/
content directory.  This file sets display:none on the box in the card view pane
when there is nothing to display, it then sets display:block when an item in the
results pane (upper right) is selected.

Comment 3

[hangas]

Attachment: Replacement file for addressbook.js to demonstrate bug

Comment 4

[Eric Vaughan]

I will have to sit down and take a look but a fix doesn't look like it will make
m7 moving to m8.

Comment 5

[Eric Vaughan]

Paul is this bug still valid? Perhaps I can sit down with you at some point and
try to figure it out.

Comment 6

[hangas]

This bug is blocking the development of two of my dialogs.  I have some crude
work-arounds that do not provide correct behavior.  I have not checked to see if
this still fails (in the past couple weeks) because I have had no news that
anything was fixed.

Comment 7

[Eric Vaughan]

Paul is this working for you now?

Comment 8

[hangas]

No, if a box contains other boxes and html:div's then setting display:none on the
outside box does not hide the div's.  Also if the box starts out with
display:none set then later set to display:block the contents to not always show
up.

Comment 9

[Peter Trudelle]

reassigning to evaughan as p2 for m9. Paul, do you want this to be set to
blocker severity, as implied by your comment?  If so, priority can be set to p1.

Comment 10

[Eric Vaughan]

Attachment: Ok here is an example the hides and show nested boxes and divs

Comment 11

[Eric Vaughan]

I can not make this happen. I have enlosed examples with boxes and divs. Can you
provide me with a sample that fails?

Comment 12

[hangas]

How about we move this to M14 and I will use my very slow workaround for PR1?  At
that point I will visit you and we can hack around with the card view JS to make
the bug happen.

Comment 13

[hangas]

I just tested this today and it is working now.  I think that this can be marked

as fixed.

Comment 14

[ckritzer (gone)]

Assigning to originator per new organizational structure.

Comment 15

[hangas]

Marking verified.  It has been working well.

Comment 16

[leger]

BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.