Boxes display incorrectly when style set to display:none

VERIFIED FIXED in M11

Status

()

P2
normal
VERIFIED FIXED
20 years ago
10 years ago

People

(Reporter: hangas, Assigned: eric)

Tracking

Trunk
PowerPC
Mac System 8.6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

20 years ago
In the Address Book window the card view pane (lower right pane) displays
incorrectly when calling setAttribute("style", "display:none") on a box
containing the card view.  It displays what appears to be the top of the window
in this lower pane.
(Assignee)

Updated

20 years ago
Status: NEW → RESOLVED
Last Resolved: 20 years ago
Resolution: --- → WORKSFORME
(Assignee)

Comment 1

20 years ago
This works for me. The following example creates a box with 2 buttons called
"hideit". It then creates 2 other buttons called "hide" and "show" that set the
"hideit" box's display to either none or block. As you will set the box appears
and disappears.

<?xml version="1.0"?>
<?xml-stylesheet href="xul.css" type="text/css"?>
<?xml-stylesheet href="navigator.css" type="text/css"?>

<!DOCTYPE window>

<window style="width: 100%; height: 100%"
xmlns:html="http://www.w3.org/TR/REC-html40"
        xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
        onConstruction="Startup()">

<html:script>
   function hide()
   {
      document.getElementById("tohide").setAttribute("style","display:none");
	  dumb("hidden");
   }
   function show()
   {
      document.getElementById("tohide").setAttribute("style","display:inline");
	  dumb("hidden");
   }
</html:script>

<box align="horizontal">
      <box id="tohide" align="vertical">
		<titledbutton src="resource:/res/toolbar/TB_Forward.gif"
align="bottom" value="Button1"/>
		<titledbutton src="resource:/res/toolbar/TB_Forward.gif"
align="bottom" value="Button2"/>
      </box>

      <titledbutton src="resource:/res/toolbar/TB_Forward.gif" align="bottom"
value="Hide" onclick="hide()"/>
      <titledbutton src="resource:/res/toolbar/TB_Forward.gif" align="bottom"
value="Show" onclick="show()"/>
</box>

</window>
(Reporter)

Updated

20 years ago
Status: RESOLVED → REOPENED
(Reporter)

Comment 2

20 years ago
I tried this simple case listed by evaughan, and it works for me too.  My
original case still fails in a big way.  I will attach a file that should be used
to replace the addressbook.js file in the mozilla/mailnews/addrbook/resources/
content directory.  This file sets display:none on the box in the card view pane
when there is nothing to display, it then sets display:block when an item in the
results pane (upper right) is selected.
(Reporter)

Comment 3

20 years ago
Created attachment 435 [details]
Replacement file for addressbook.js to demonstrate bug

Updated

20 years ago
Resolution: WORKSFORME → ---
(Assignee)

Updated

20 years ago
Target Milestone: M8
(Assignee)

Comment 4

20 years ago
I will have to sit down and take a look but a fix doesn't look like it will make
m7 moving to m8.
(Assignee)

Updated

20 years ago
Status: REOPENED → ASSIGNED
Target Milestone: M8 → M9
(Assignee)

Comment 5

20 years ago
Paul is this bug still valid? Perhaps I can sit down with you at some point and
try to figure it out.
(Reporter)

Comment 6

20 years ago
This bug is blocking the development of two of my dialogs.  I have some crude
work-arounds that do not provide correct behavior.  I have not checked to see if
this still fails (in the past couple weeks) because I have had no news that
anything was fixed.
(Assignee)

Comment 7

20 years ago
Paul is this working for you now?
(Assignee)

Updated

20 years ago
Assignee: evaughan → hangas
Status: ASSIGNED → NEW
(Reporter)

Comment 8

20 years ago
No, if a box contains other boxes and html:div's then setting display:none on the
outside box does not hide the div's.  Also if the box starts out with
display:none set then later set to display:block the contents to not always show
up.
(Reporter)

Updated

20 years ago
Assignee: hangas → trudelle

Updated

20 years ago
Assignee: trudelle → evaughan
Priority: P3 → P2

Comment 9

20 years ago
reassigning to evaughan as p2 for m9. Paul, do you want this to be set to
blocker severity, as implied by your comment?  If so, priority can be set to p1.
(Assignee)

Updated

20 years ago
Status: NEW → ASSIGNED
Target Milestone: M9 → M10
(Assignee)

Comment 10

19 years ago
Created attachment 1628 [details]
Ok here is an example the hides and show nested boxes and divs
(Assignee)

Comment 11

19 years ago
I can not make this happen. I have enlosed examples with boxes and divs. Can you
provide me with a sample that fails?
(Assignee)

Updated

19 years ago
Target Milestone: M10 → M11
(Reporter)

Comment 12

19 years ago
How about we move this to M14 and I will use my very slow workaround for PR1?  At
that point I will visit you and we can hack around with the card view JS to make
the bug happen.
(Reporter)

Comment 13

19 years ago
I just tested this today and it is working now.  I think that this can be marked

as fixed.
(Assignee)

Updated

19 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 20 years ago19 years ago
Resolution: --- → FIXED

Updated

19 years ago
QA Contact: ckritzer → hangas

Comment 14

19 years ago
Assigning to originator per new organizational structure.
(Reporter)

Updated

19 years ago
Status: RESOLVED → VERIFIED
(Reporter)

Comment 15

19 years ago
Marking verified.  It has been working well.

Comment 16

19 years ago
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL

Updated

10 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: hangas → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.