Closed
Bug 814748
Opened 13 years ago
Closed 13 years ago
Provide the ability to enable/disable xpcshell tests for per-window private browsing builds
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla20
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.53 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #684746 -
Flags: review?(ted)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 684746 [details] [diff] [review]
Patch (v1)
Review of attachment 684746 [details] [diff] [review]:
-----------------------------------------------------------------
::: config/writemozinfo.py
@@ +66,5 @@
> # crashreporter
> d["crashreporter"] = 'MOZ_CRASHREPORTER' in env and env['MOZ_CRASHREPORTER'] == '1'
> +
> + # per-window private browsing
> + d["perwindowpb"] = 'MOZ_PER_WINDOW_PRIVATE_BROWSING' in env and env['MOZ_PER_WINDOW_PRIVATE_BROWSING'] == '1'
"perwindowpb" is a little hard to read. I know it's unwieldy, but "perwindowprivatebrowsing" would be clearer.
Attachment #684746 -
Flags: review?(ted) → review+
|
|
||
Updated•13 years ago
|
Assignee: nobody → ehsan
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•