Closed Bug 814748 Opened 7 years ago Closed 7 years ago

Provide the ability to enable/disable xpcshell tests for per-window private browsing builds

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla20

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

Attached patch Patch (v1)Splinter Review
No description provided.
Attachment #684746 - Flags: review?(ted)
Blocks: 814749
Comment on attachment 684746 [details] [diff] [review]
Patch (v1)

Review of attachment 684746 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/writemozinfo.py
@@ +66,5 @@
>      # crashreporter
>      d["crashreporter"] = 'MOZ_CRASHREPORTER' in env and env['MOZ_CRASHREPORTER'] == '1'
> +
> +    # per-window private browsing
> +    d["perwindowpb"] = 'MOZ_PER_WINDOW_PRIVATE_BROWSING' in env and env['MOZ_PER_WINDOW_PRIVATE_BROWSING'] == '1'

"perwindowpb" is a little hard to read. I know it's unwieldy, but "perwindowprivatebrowsing" would be clearer.
Attachment #684746 - Flags: review?(ted) → review+
Assignee: nobody → ehsan
https://hg.mozilla.org/mozilla-central/rev/9102b22a9765
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.