Closed
Bug 814822
Opened 12 years ago
Closed 12 years ago
hal doesn't notify listeners when a wakelock is released due to child process dying
Categories
(Core :: Hardware Abstraction Layer (HAL), defect)
Tracking
()
People
(Reporter: dhylands, Assigned: kanru)
References
Details
Attachments
(1 file)
2.43 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
When a wakelock is released due to a child process crash, listeners which have registered with the nsIDOMMozPowerManager::AddWakeLockListener don't get notified (i.e. NotifyWakeLockChange doesn't get called)
Reporter | ||
Comment 1•12 years ago
|
||
nom'd since this blocks a blocking bug
Blocks: 806363
blocking-basecamp: --- → ?
Summary: hal doesn't notify listeners when a wkelock is released due to child process dying → hal doesn't notify listeners when a wakelock is released due to child process dying
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → kchen
Assignee | ||
Comment 2•12 years ago
|
||
CountWakeLocks is moved before RemoveChildFromList. Also clear the sLockTable when wake lock count is 0. Assert that ModifyWakeLockInternal should only be called from main thread.
Attachment #685027 -
Flags: review?(justin.lebar+bug)
Updated•12 years ago
|
Attachment #685027 -
Flags: review?(justin.lebar+bug) → review+
Reporter | ||
Comment 3•12 years ago
|
||
I can confirm that this works for me now. Thanks
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/876bed348636
Updated•12 years ago
|
blocking-basecamp: ? → +
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/876bed348636
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/82dcfd62c689 https://hg.mozilla.org/releases/mozilla-beta/rev/9fd912a263a6
You need to log in
before you can comment on or make changes to this bug.
Description
•