814898 - Cleanup CC goop in parts of dom/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: dom/file

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: dom/base

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part c: dom/B2G

Comment 4

[Mounir Lamouri (:mounir)]

Ms2ger, unfortunately, those reviews are not going to be high priority in my queue and compared to other stuff I have to do. Hopefully, I might do them this week or next week but do not expect anything faster. Sorry :(

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 685527 [details] [diff] [review]
Part b: dom/base

Review of attachment 685527 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsScreen.cpp
@@ +89,5 @@
>  
>  
>  DOMCI_DATA(Screen, nsScreen)
>  
> +NS_IMPL_CYCLE_COLLECTION_INHERITED_0(nsScreen, nsDOMEventTargetHelper)

I'm not sure you actually need to explicitly define a participant, as it should just be able to use the one of its parent. I'm not sure exactly what you need to remove for that, though.

Comment 6

[Andrew McCreight [:mccr8]]

Comment on attachment 685528 [details] [diff] [review]
Part c: dom/B2G

Review of attachment 685528 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/battery/BatteryManager.cpp
@@ +26,5 @@
>  namespace mozilla {
>  namespace dom {
>  namespace battery {
>  
> +NS_IMPL_CYCLE_COLLECTION_INHERITED_0(BatteryManager, nsDOMEventTargetHelper)

Again, you can probably adjust this somehow so it just inherits all of its CC goop, and various other classes in here. Not a big deal, of course.

Comment 7

[Mounir Lamouri (:mounir)]

Thank you Andrew :)

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part d: Some more

I found a few more

Comment 9

[Andrew McCreight [:mccr8]]

Thanks for fixing these!

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/72cf2fca6f9a
https://hg.mozilla.org/mozilla-central/rev/6efba13355b2
https://hg.mozilla.org/mozilla-central/rev/c4ef225eaa85
https://hg.mozilla.org/mozilla-central/rev/64855ea171ef