If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Cleanup CC goop in parts of dom/

RESOLVED FIXED in mozilla20

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
mozilla20
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Component: DOM: Device Interfaces → DOM
Summary: Cleanup CC goop in dom/file → Cleanup CC goop in parts of dom/
(Assignee)

Comment 1

5 years ago
Created attachment 685526 [details] [diff] [review]
Part a: dom/file
Attachment #685526 - Flags: review?(mounir)
(Assignee)

Comment 2

5 years ago
Created attachment 685527 [details] [diff] [review]
Part b: dom/base
Attachment #685527 - Flags: review?(mounir)
(Assignee)

Comment 3

5 years ago
Created attachment 685528 [details] [diff] [review]
Part c: dom/B2G
Attachment #685528 - Flags: review?(mounir)
Ms2ger, unfortunately, those reviews are not going to be high priority in my queue and compared to other stuff I have to do. Hopefully, I might do them this week or next week but do not expect anything faster. Sorry :(
Attachment #685526 - Flags: review?(mounir) → review+
Comment on attachment 685527 [details] [diff] [review]
Part b: dom/base

Review of attachment 685527 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsScreen.cpp
@@ +89,5 @@
>  
>  
>  DOMCI_DATA(Screen, nsScreen)
>  
> +NS_IMPL_CYCLE_COLLECTION_INHERITED_0(nsScreen, nsDOMEventTargetHelper)

I'm not sure you actually need to explicitly define a participant, as it should just be able to use the one of its parent. I'm not sure exactly what you need to remove for that, though.
Attachment #685527 - Flags: review?(mounir) → review+
Comment on attachment 685528 [details] [diff] [review]
Part c: dom/B2G

Review of attachment 685528 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/battery/BatteryManager.cpp
@@ +26,5 @@
>  namespace mozilla {
>  namespace dom {
>  namespace battery {
>  
> +NS_IMPL_CYCLE_COLLECTION_INHERITED_0(BatteryManager, nsDOMEventTargetHelper)

Again, you can probably adjust this somehow so it just inherits all of its CC goop, and various other classes in here. Not a big deal, of course.
Attachment #685528 - Flags: review?(mounir) → review+
Thank you Andrew :)
(Assignee)

Comment 8

5 years ago
Created attachment 686785 [details] [diff] [review]
Part d: Some more

I found a few more
Attachment #686785 - Flags: review?(continuation)
Attachment #686785 - Flags: review?(continuation) → review+
Thanks for fixing these!
(Assignee)

Comment 10

5 years ago
https://hg.mozilla.org/mozilla-central/rev/72cf2fca6f9a
https://hg.mozilla.org/mozilla-central/rev/6efba13355b2
https://hg.mozilla.org/mozilla-central/rev/c4ef225eaa85
https://hg.mozilla.org/mozilla-central/rev/64855ea171ef
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.