implement CSSGroupingRule and CSSConditionRule

RESOLVED FIXED in mozilla20

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

({dev-doc-complete})

Trunk
mozilla20
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

7 years ago
No description provided.
Assignee

Comment 1

7 years ago
Posted patch patch (obsolete) — Splinter Review
Note that I changed the serialisation of @-moz-document rules to remove an extra space after the condition.  I've left SetConditionText() unimplemented, like SetCssText() is.
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #684903 - Flags: review?(bzbarsky)
Assignee

Updated

7 years ago
Blocks: 815021
Assignee

Comment 2

7 years ago
Posted patch patch (v1.1)Splinter Review
Force @supports pref on in the test.
Attachment #684903 - Attachment is obsolete: true
Attachment #684903 - Flags: review?(bzbarsky)
Attachment #685019 - Flags: review?(bzbarsky)
Comment on attachment 685019 [details] [diff] [review]
patch (v1.1)

The XPIDL bits make me cry, but converting this to WebIDL is a fight for another day.

Please post to www-style requesting corresponding changes to CSSOM?

>+++ b/dom/interfaces/css/nsIDOMCSSGroupingRule.idl
>+ * Interface for at-rules in the CSS OM.

"at-rules that have child rules"

I'm trying to figure out the usefulness of conditionText if one gets it without checking what sort of condition rule one has.  It has pretty different behavior for @-moz-document and @supports, no?  What's the benefit of having a single interface that hands out strings that mean totally different things depending on which instance of the interface you have?

Apart from that this looks ok, but I'd like to understand the API design here.
Assignee

Comment 4

7 years ago
So these interface changes are already in the css3-conditional spec, I was just following them.  That conditionText should go on CSSConditionRule was a recent WG decision, I believe.

Whether having conditionText there and not individually on each of CSSMediaRule, CSSDocumentRule (when that goes into css4-conditional) and CSSSupportsRule, possibly with different names, is useful, I'm not sure.  (It might be useful for a style sheet editing UI that lets you double click to edit the condition?)  Maybe dbaron could say more.
Comment on attachment 685019 [details] [diff] [review]
patch (v1.1)

Ah, ok.  If dbaron is already on board with the interface chnages, r=me
Attachment #685019 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/cb43db016af6
https://hg.mozilla.org/mozilla-central/rev/62bb8cc3277b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.