81494 - Duplicate POP limit download size pref: Server, Offline panels-changes in Offline don't take

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect, P2)

Description

[laurel]

Using may17 commercial trunk build

We have inadvertently wound up with duplicate prefs for the POP limit download
size.  It has been residing in the Server panel and when Offline&DiskSpace panel
was added for each account, it appears there as "Do not download message bodies
that are larger than N kb".  We only need one instance.

Comments from David Bienvenu via email: 
"There should only be one; Laurel is right. Where it goes is debatable. If we
want to be consistent across pop, imap, and news, it should go in the
offline/disk space panel.  If we could get rid of the offline disk space panel
for pop, then we should put it in the server settings for pop. I think for ease
of use for pop users, having one less place to look for settings would be good.
But I don't feel strongly about it."

We need to decide where it will reside and remove the other.

Comment 1

[scottputterman]

Jennifer, any opinions?  I think it would be easier to get rid of the one in the
server panel right now.

moving to 0.9.2, but I'd argue for it for 0.9.1 if a fix were to exist.

Comment 2

[jglick]

No strong opinions on this one. 

1. Relocate both disk space prefs for POP to server panel and get rid of Offline 
& Disk Space for POP.  Pro: One less panel.

2. Keep both Disk Space type prefs together on a separate panel. Offline & 
Diskspace should really be just "Diskspace" for POP. Pro: parallel location with 
IMAP and NEWS accounts so easier for users find location.  Will there be 
additional items in the future?

Comment 3

[laurel]

Reminder: if we do option #1 and get rid of the Offline panel for POP, we need
to remove the "Offline Settings" link from Account Central for POP accounts.

Comment 4

[jglick]

POP Account Central probably shouldn't have "Offline Settings" anyway, since 
there really aren't any offline settings for POP (just Disk Space).

Comment 5

[laurel]

If we're agreed on that, I'll log a separate account central bug?

Comment 6

[esther]

With these duplicates, checking or unchecking this
option or changing the size limit in the Offline panel does not reflect in the
Server panel.  If user closes the Account settings at this point the changes
aren't saved.  
The suggested fix is to remove it from the Server panel, if this is done we need
to make sure the Offline panel holds the changes.  

Comment 7

[esther]

FYI..per comment on 5-22-01, I could not find a bug for removing the Offline
Settings from Account Central (which is a separate bug) so I logged one 83594.  

Comment 8

[laurel]

Esther, there is already a bug about the remembering of the pref 82984. 

Comment 9

[racham]

Jennifer,

Just pinging to know if there is a general consent reached on this one in any 
of your meetings.

There is a suggestion to get rid of the offline panel altogether for POP and 
having the pref in server panel only. But, I think it is better to leave the one 
in offline & diskspace panel (I knmow there are offline items in pop panel 
today) and remove the one in Server Panel, particularly given the fact that we 
are trying reduce the AccountManager window size (bug 82122). So, it will be 
better if we can even out the distribution of prefs whereever possible. Also, it 
will be nice to see that panel exists for POP also as it offers better user 
experience and easier for us to manage the code also (as such there is some 
level offline support for POP accounts). If we have to get rid of it 
for POP accounts only, I have to start doing special things for POP accounts in 
UI to not show offline item.

Anyway, Let me know if this one was discussed later.

bhuvan

Comment 10

[scottputterman]

moving to 0.9.3 per PDT

Comment 11

[racham]

Attachment: patch to remove the pref from server panel

Comment 12

[jglick]

bhuvan, no "official" decision, but so far I think Putterman, you and I agree 
that keeping both Disk Space type prefs together on a separate panel is 
preferable, so lets go with that.

Comment 13

[racham]

Time to get reviews and check this in. 

Will request diane and Seth for r/sr. Will send a email request also.

bhuvan 

Comment 14

[Diane Sun]

r=dianesun

Comment 15

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 16

[racham]

Fixed on trunk.

Leaving the bug open until the branch checkin.

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED (*TRUNK*) : 

The setting "Limit message download to X kB per message" is no longer underneath
'Server Settings' in the Account Manager.  It remains now (was here before) in
category 'Disk Space', "Do not download messages locally that are larger than X kB"

Windows 2K - 2001-06-29-04
Mac OS 9.1 - 2001-06-29-05
RedHat 7.1 - 2001-06-29-06

Comment 18

[lchiang]

adding vtrunk keyword to indicate the bug has been fixed on the trunk.  Bug left
open for tracking checkin to branch (nsbranch) when appropriate.

Once bug has been fixed on the branch also, pls remove vtrunk keyword.

Comment 19

[scottputterman]

adding nsbranch+. But, can you leave out the dtd change?  My understanding is
that even removing strings can mess up localization and having them on the
branch shouldn't cause any harm.

Comment 20

[esther]

trunkverified

Comment 21

[scottputterman]

When the branch is open, please check this into it today.

Comment 22

[racham]

checked in on the branch. 

Marking fixed. Removing vtrunk keyword.

Comment 23

[laurel]

Verified OK using jul09 commercial 0.9.2 branch builds with win98, mac OS 9.0
and linux rh6.2

Comment 24

[laurel]

Added note: the limit download feature isn't working quite right, but there's an
existing bug 74781 on it.  Message doesn't auto-refresh when clicking on link to
retrieve the rest of the message.