Closed
Bug 815001
Opened 12 years ago
Closed 12 years ago
Error: Not enough arguments [nsIWebBrowserPersist.saveURI]
Categories
(Toolkit :: View Source, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: alice0775, Assigned: ehsan.akhgari)
References
(Depends on 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
2.86 KB,
patch
|
jdm
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Error: Not enough arguments [nsIWebBrowserPersist.saveURI] = NS_ERROR_XPC_NOT_ENOUGH_ARGS Source file: chrome://global/content/viewSourceUtils.js Line: 120 MXR: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/viewsource/content/viewSourceUtils.js#120 Steps to reproduce; 1. Make sure to use External Editor for ViewSource 2. Run the following statement in Browser context of ScratchPad. gViewSourceUtils.openInExternalEditor("http://mxr.mozilla.org/mozilla-central/source/toolkit/components/viewsource/content/viewSourceUtils.js#120", null, null, null, null); Actual results: Error appears in Error console. Nothing happens. Expected results: No Error. External editor should open.
Reporter | ||
Comment 1•12 years ago
|
||
Alternative Steps to reproduce; 1. Make sure to use External Editor for ViewSource 2. Open Error Console 3. Click a link of any Warning / Error Actual results: Error appears in Error console. Internal SourceViewer is opened instead of External editor Expected results: No Error. External editor should open.
Comment 2•12 years ago
|
||
Whoops. There's a loadContext parameter missing from the saveURI call at http://mxr.mozilla.org/mozilla-central/source/toolkit/components/viewsource/content/viewSourceUtils.js#120.
Assignee | ||
Comment 3•12 years ago
|
||
Assignee | ||
Comment 4•12 years ago
|
||
Comment on attachment 685212 [details] [diff] [review] Patch (v1) [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 794602 User impact if declined: see comment 0 Testing completed (on m-c, etc.): locally Risk to taking this patch (and alternatives if risky): This patch has extremely minimal risk. We can't really backout bug 794602 since it blocks bug 787743. String or UUID changes made by this patch: none.
Attachment #685212 -
Flags: approval-mozilla-beta?
Attachment #685212 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 5•12 years ago
|
||
Not sure why this was marked as addon-compat.
Keywords: addon-compat
Updated•12 years ago
|
Attachment #685212 -
Flags: review?(josh) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a9cb961441d
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4a9cb961441d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment 8•12 years ago
|
||
Minimal user impact, but also minimal risk. Since this is a regression in FF18 and we're still early in the beta cycle, we can land this on branches. No need to track for release though.
Updated•12 years ago
|
Attachment #685212 -
Flags: approval-mozilla-beta?
Attachment #685212 -
Flags: approval-mozilla-beta+
Attachment #685212 -
Flags: approval-mozilla-aurora?
Attachment #685212 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 9•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b3fbd7b77b31 https://hg.mozilla.org/releases/mozilla-beta/rev/e7691ac43ed5
Reporter | ||
Comment 10•9 years ago
|
||
See, bug 1116880 that is the same kind of recession bug. Please provide automate test to prevent same problem.
Flags: needinfo?(ehsan)
Reporter | ||
Comment 11•9 years ago
|
||
s/recession/regression/
Assignee | ||
Comment 12•9 years ago
|
||
(In reply to Alice0775 White from comment #10) > See, bug 1116880 that is the same kind of recession bug. That bug has nothing to do with this, it was regressed by bug 704320 which added an argument to savePrivacyAwareURI and forgot to update this caller.
Flags: needinfo?(ehsan)
Reporter | ||
Comment 13•9 years ago
|
||
If we had been added a test in this bug. The regression from bug 704320 have been been obviated...
You need to log in
before you can comment on or make changes to this bug.
Description
•