Closed
Bug 815044
Opened 13 years ago
Closed 13 years ago
SpiderMonkey decompiler has unnecessarily non-static functions
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: jimb, Unassigned)
Details
Attachments
(1 file)
There are a few functions in js/src/jsopcode.cpp that are not used outside that file, but are nonetheless declared as visible throughout SpiderMonkey in jsopcode.h, rather than being static to jsopcode.cpp.
The attached patch makes those functions static to jsopcode.cpp, and renames them appropriately.
It also deletes js_DecompileFunctionBody, which is unused.
Attachment #685041 -
Flags: review?(jorendorff)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 685041 [details] [diff] [review]
Make js_DecompileScript, and js_DecompileFunction static to jsopcode.cpp. Delete js_DecompileFunctionBody; it is unused.
Review of attachment 685041 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks.
Attachment #685041 -
Flags: review?(jorendorff) → review+
|
Reporter | |
Comment 2•13 years ago
|
||
Flags: in-testsuite-
Target Milestone: --- → mozilla20
|
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•