815056 - Build warning while building jsarray.cpp: "forkjoin.h:158:34: warning: inline function ‘static js::ForkJoinSlice* js::ForkJoinSlice::current()’ used but never defined [enabled by default]"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning encountered today in my opt m-c build:
{
In file included from /mozilla/js/src/jsarray.cpp:93:0:

Warning: enabled by default in /mozilla/js/src/vm/forkjoin.h: inline function ‘static js::ForkJoinSlice* js::ForkJoinSlice::current()’ used but never defined

/mozilla/js/src/vm/forkjoin.h:158:34: warning: inline function ‘static js::ForkJoinSlice* js::ForkJoinSlice::current()’ used but never defined [enabled by default]
}

Looks like this is from code added a few days ago in bug 801087.  The used-but-never-defined function lives in forkjoininlines.h, and in fact it's the only thing in that file. Perhaps forkjoininlines.h should just be merged into forkjoin.h?  That, or jsarray.cpp needs to #include forkjoininlines.h

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

I went with the latter (more conservative) approach from comment 0 -- just including the inlines file in jsarray.cpp.  Confirmed that this fixes the warning.

Comment 2

[Niko Matsakis [:nmatsakis]]

This is fixed in the patch for 825714 (which has not yet landed)

Comment 3

[Daniel Holbert [:dholbert]]

Looks like bug 825714 has landed, and I don't remember seeing this warning go by recently, so I think this was fixed per comment 2.