Closed Bug 815071 Opened 8 years ago Closed 8 years ago
Update jemalloc 3 to (mostly) 3
I'd like to update jemalloc3 to commit 9906660eb7365abb54e4495407ffddb1069ef654, which only differs from the 3.2.0 release with http://www.canonware.com/pipermail/jemalloc-discuss/2012-November/000517.html and another patch to the jemalloc profiling feature that we don't enable, so it's essentially a no-op patch.
Comment on attachment 685073 [details] [diff] [review] Update jemalloc3 to commit 9906660 There's a bug in arenas_extend_ctl that makes it fail to build on windows, and build something very wrong on other platforms.
This updates to commit 6eb84fbe315add1e1d4f8deedc25d260fff3ae97, but I want http://www.canonware.com/pipermail/jemalloc-discuss/2012-November/000527.html for bug 804303, and it's not committed upstream yet.
Attachment #685073 - Attachment is obsolete: true
Comment on attachment 687667 [details] [diff] [review] Update jemalloc3 to commit 6eb84fb That can land without http://www.canonware.com/pipermail/jemalloc-discuss/2012-November/000527.html for bug 804303 for now. The only impact of not having that patch is there's a possibility of a dead-lock on fork() when building with --enable-replace-malloc *and* running with the libreplace_jemalloc.dylib lib on mac. And that patch actually introduces another more important problem with libreplace_jemalloc.dylib, so all in all, it's not that bad not to land with it.
Attachment #687667 - Flags: review?(justin.lebar+bug)
Attachment #687667 - Flags: review?(justin.lebar+bug) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment on attachment 687667 [details] [diff] [review] Update jemalloc3 to commit 6eb84fb [Approval Request Comment] User impact if declined: required for bug 804303 Testing completed (on m-c, etc.): baked on m-i/m-c for a few days Risk to taking this patch (and alternatives if risky): NPOTB String or UUID changes made by this patch: none
https://hg.mozilla.org/releases/mozilla-aurora/rev/e04eec5f7c6d This didn't apply cleanly to beta, so I didn't push it there.
The base jemalloc version was a different one, but updating only requires changing upstream.info and running update.sh. http://hg.mozilla.org/releases/mozilla-b2g18/rev/fc084e346eb5
Good to know for the future, thanks!
Attachment #687667 - Flags: approval-mozilla-beta+ → approval-mozilla-b2g18+
5 years ago
You need to log in before you can comment on or make changes to this bug.