Closed Bug 815071 Opened 10 years ago Closed 10 years ago

Update jemalloc 3 to (mostly) 3.2


(Core :: Memory Allocator, defect)

Not set



Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed


(Reporter: glandium, Assigned: glandium)




(1 file, 1 obsolete file)

I'd like to update jemalloc3 to commit 9906660eb7365abb54e4495407ffddb1069ef654, which only differs from the 3.2.0 release with and another patch to the jemalloc profiling feature that we don't enable, so it's essentially a no-op patch.
Attachment #685073 - Flags: review?(justin.lebar+bug)
Comment on attachment 685073 [details] [diff] [review]
Update jemalloc3 to commit 9906660

There's a bug in arenas_extend_ctl that makes it fail to build on windows, and build something very wrong on other platforms.
Attachment #685073 - Flags: review?(justin.lebar+bug)
This updates to commit 6eb84fbe315add1e1d4f8deedc25d260fff3ae97, but I want for bug 804303, and it's not committed upstream yet.
Attachment #685073 - Attachment is obsolete: true
Comment on attachment 687667 [details] [diff] [review]
Update jemalloc3 to commit 6eb84fb

That can land without for bug 804303 for now. The only impact of not having that patch is there's a possibility of a dead-lock on fork() when building with --enable-replace-malloc *and* running with the libreplace_jemalloc.dylib lib on mac. And that patch actually introduces another more important problem with libreplace_jemalloc.dylib, so all in all, it's not that bad not to land with it.
Attachment #687667 - Flags: review?(justin.lebar+bug)
Attachment #687667 - Flags: review?(justin.lebar+bug) → review+
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment on attachment 687667 [details] [diff] [review]
Update jemalloc3 to commit 6eb84fb

[Approval Request Comment]
User impact if declined: required for bug 804303
Testing completed (on m-c, etc.): baked on m-i/m-c for a few days
Risk to taking this patch (and alternatives if risky): NPOTB
String or UUID changes made by this patch: none
Attachment #687667 - Flags: approval-mozilla-beta?
Attachment #687667 - Flags: approval-mozilla-aurora?
Attachment #687667 - Flags: approval-mozilla-beta?
Attachment #687667 - Flags: approval-mozilla-beta+
Attachment #687667 - Flags: approval-mozilla-aurora?
Attachment #687667 - Flags: approval-mozilla-aurora+

This didn't apply cleanly to beta, so I didn't push it there.
The base jemalloc version was a different one, but updating only requires changing and running
Whiteboard: [status-b2g18:fixed]
Good to know for the future, thanks!
Whiteboard: [status-b2g18:fixed]
Attachment #687667 - Flags: approval-mozilla-beta+ → approval-mozilla-b2g18+
You need to log in before you can comment on or make changes to this bug.