815076 - The default Twitter search engine does not work

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Adrian Tamas (:AdrianT)]

Aurora 19.0a2 2012-11-22/ Nightly 20.0a1 2012-11-22/ Firefox Mobile 18.0b1
Asus EEE Transformers TF101 (Android 4.0.3)/ Samsung Galaxy Nexus (Android 4.1.1)

Steps:
1. Sign in to twitter.com
2. In a new tab tap in the Awesomescreen and enter any word (e.g. "mozilla") in the URL bar
3. Search using twitter

Expected:
All tweets containing the word are displayed

Actual:
No results are displayed.
Looking a bit more into this there is a "/" from the link. Firefox Mobile performs the search using this string: "https://mobile.twitter.com/search?q=mozilla"  and for twitter it should use this string: "https://mobile.twitter.com/search/?q=mozilla" .

Comment 1

[Aaron Train [:aaronmt]]

Confirmed.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch adds the trailing '/'

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/537865efa182

Comment 4

[Aaron Train [:aaronmt]]

Channel nom?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 685274 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Broken search on twitter
Testing completed (on m-c, etc.): landed on m-c and verified
Risk to taking this patch (and alternatives if risky): Very small. Limited to Twitter search only
String or UUID changes made by this patch: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e4c679d061f7
https://hg.mozilla.org/releases/mozilla-beta/rev/6c14548dbd4e

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

We don't ship ESR mobile so wontfixing for esr17

Comment 8

[Adrian Tamas (:AdrianT)]

Verified on Smasung Galaxy Tab (Android 3.1) on Firefox Mobile 18 beta 5 and Aurora 19.0a2 2012-12-19. The Twitter search engine works now.