815091 - Support for international prefixes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Andrea Marchesini [:baku]]

Currently only france, brazil, UK, US are supported.
I wrote a patch that adds any international prefix: https://en.wikipedia.org/wiki/Country_calling_code

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 685096 [details] [diff] [review]
patch

Review of attachment 685096 [details] [diff] [review]:
-----------------------------------------------------------------

We could maybe have a "grab bag path" with all the prefixes but I'd like to keep the proper trunk code support when we have the data (and not generate extra variants).

But the main issue is: we should check to see if the international numbers support is going to be handled by the platform for the Dialer too (it is for the SMS app).

::: shared/js/simple_phone_matcher.js
@@ +86,5 @@
>    _mccWith00Prefix: ['208', '214', '234', '235', '724'],
>    _mccWith011Prefix: ['310', '311', '312', '313', '314', '315', '316'],
>  
> +  // https://en.wikipedia.org/wiki/Country_calling_code
> +  _countryPrefixes: [

The issue is, we're loosing the Trunk Code support here which will cause extra variants to be generated which can cause false matches...

Comment 3

[Etienne Segonzac (:etienne)]

Gregor do you know about the telephony API doing international numbers stuffs?

Comment 4

[Andrea Marchesini [:baku]]

Maybe we can have: _countryPrefixes: [ { p: 44, tc: false },...
so we can change the trunk code variant only if needed.

Comment 5

[Etienne Segonzac (:etienne)]

(In reply to Andrea Marchesini (:baku) from comment #4)
> Maybe we can have: _countryPrefixes: [ { p: 44, tc: false },...
> so we can change the trunk code variant only if needed.

I like this idea :)

Comment 6

[Andrea Marchesini [:baku]]

Attachment: patch b

Comment 7

[Gregor Wagner [:gwagner]]

We should have all this in https://hg.mozilla.org/mozilla-central/file/597915b66059/dom/phonenumberutils

But we have to connect it.

Comment 8

[Andrea Marchesini [:baku]]

Gregor, do we have any plan to connect this phone number module?
Is this a public API?

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 685151 [details] [diff] [review]
patch b

Review of attachment 685151 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comment explaining the structure added

::: shared/js/simple_phone_matcher.js
@@ +86,4 @@
>    _mccWith00Prefix: ['208', '214', '234', '235', '724'],
>    _mccWith011Prefix: ['310', '311', '312', '313', '314', '315', '316'],
>  
> +  // https://en.wikipedia.org/wiki/Country_calling_code

Please add a comment explaining the format of the |_countryPrefixes| array and mentioning https://en.wikipedia.org/wiki/Trunk_code

Comment 10

[Andrea Marchesini [:baku]]

Attachment: patch c

I sent a pulll request: https://github.com/mozilla-b2g/gaia/pull/6678

Comment 11

[Andrea Marchesini [:baku]]

Comment on attachment 686054 [details] [diff] [review]
patch c

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
User impact if declined: Right now, the international phone numbers are not associated with contacts.
Risk to taking this patch (and alternatives if risky): I don't see any risk.

Comment 12

[Andrea Marchesini [:baku]]

Fabrice, can you take a look at this?

Comment 13

[Andrea Marchesini [:baku]]

https://github.com/mozilla-b2g/gaia/pull/7028

Comment 14

[Panos Astithas (he/him) [:past] (please ni?)]

Can someone merge this please? It seems to be approved and ready to land as far as I can tell.

Comment 15

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/02e88072898f0f6d2427b2e69c20fded62ed4692