815145 - Remove the JS REPL from shell.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[[:fabrice] Fabrice Desré]

Attachment: patch

We now have the remote debugger which is better in many ways.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 685162 [details] [diff] [review]
patch

Review of attachment 685162 [details] [diff] [review]:
-----------------------------------------------------------------

Die.

Comment 2

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/51b9c55fed74

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 685162 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: all b2g devices listen on port 9999 to execute arbitrary javascript with chrome privileges
Testing completed (on m-c, etc.): no testing needed, just code removal
Risk to taking this patch (and alternatives if risky): no risk
String or UUID changes made by this patch: none

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 685162 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: all b2g devices allow execution of arbitrary js code with chrome privileges
Testing completed (on m-c, etc.): no testing, only code removal
Risk to taking this patch (and alternatives if risky): no risk
String or UUID changes made by this patch: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/51b9c55fed74

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d9f1abbb3885
https://hg.mozilla.org/releases/mozilla-beta/rev/0e48638a0a67