815156 - B2G RIL: Expose serviceClass to DOM via nsIDOMMozMobileCFInfo

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P1)

Description

[Fernando Jiménez Moreno [:ferjm]]

We need to expose the 'serviceClass' value provided by the RIL when querying for the call forwarding status. This is required to properly show the call forwarding status based on the service for which the call forward is set up.

Comment 1

[Andrew Overholt [:overholt]]

Is this required for certification?  It seems like support for MMI codes for call forwarding (bug 793192) has already landed yet this blocks it so I'm confused :)

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

This is a bug in the MMI support for call forwarding. I am afraid that this feature won't work properly if we don't solve it. So, yes, this is required for certification.

jaoo or me will be looking into it as soon as possible.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: WIP

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

jaoo will be working on the follow up.

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v1

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github WIP branch: https://github.com/jaoo/gaia/tree/815156

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/6751

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 686814 [details] [diff] [review]
v1

Review of attachment 686814 [details] [diff] [review]:
-----------------------------------------------------------------

Nice patch! Thanks!

You are gonna need sr for the IDL changes.

::: dom/system/gonk/ril_worker.js
@@ +3718,5 @@
> +      default:
> +        return ICC_SERVICE_CLASS_NONE;
> +    }
> +  },
> + 

nit: extra space

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 687040 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/6751

r=me

Comment 10

[Andrew Overholt [:overholt]]

Setting priority based on triage discussions.  Feel free to decrease priority if you disagree.

Comment 11

[José Antonio Olivera Ortega [:jaoo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5a6495fbff6

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #7)
> Created attachment 687040 [details]
> Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/6751

https://github.com/mozilla-b2g/gaia/commit/7071d327c408542983e520081af84d3c20bdee8e

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e5a6495fbff6

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/44d76bdf48e2
https://hg.mozilla.org/releases/mozilla-beta/rev/34deff78c620