815158 - Make HTMLElement.ontouch* work with tristate dom.w3c_touch_events.enabled

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

A bit of a hack, ideally we'd also support a callback to enable/disable properties (like we do for interfaces). But this blocks converting HTMLElement to new DOM bindings.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 685171 [details] [diff] [review]
v1

Can we get away with doing the SetBool() only once?

For example, just call nsDOMTouchEvent::PrefEnabled() here, and have _that_ do the pref-setting, since it already has static boolean guards and whatnot.

Or just add a static boolean guard here.

r=me with either approach.

Comment 2

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c2011091748

Comment 3

[(no longer active)]

Backed out because of test failures: https://hg.mozilla.org/integration/mozilla-inbound/rev/5de5d3950328

Comment 4

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7be28e2ce121

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7be28e2ce121