Closed Bug 815158 Opened 8 years ago Closed 8 years ago

Make HTMLElement.ontouch* work with tristate dom.w3c_touch_events.enabled

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: peterv, Assigned: peterv)

References

Details

Attachments

(1 file)

Attached patch v1Splinter Review
A bit of a hack, ideally we'd also support a callback to enable/disable properties (like we do for interfaces). But this blocks converting HTMLElement to new DOM bindings.
Attachment #685171 - Flags: review?(bzbarsky)
Comment on attachment 685171 [details] [diff] [review]
v1

Can we get away with doing the SetBool() only once?

For example, just call nsDOMTouchEvent::PrefEnabled() here, and have _that_ do the pref-setting, since it already has static boolean guards and whatnot.

Or just add a static boolean guard here.

r=me with either approach.
Attachment #685171 - Flags: review?(bzbarsky) → review+
Blocks: 804631
https://hg.mozilla.org/mozilla-central/rev/7be28e2ce121
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.