815246 - GCLI helper buttons shouldn't be available in the remote window

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Rob Campbell [:rc] (:robcee)]

The GCLI helper buttons (Tilt cube, Scratchpad and Responsive View) should not be visible when the Developer Tools are launched in Remote mode. They don't work.

One possibility would be to put them in the global toolbar next to the command line.

Comment 1

[Joe Walker [:jwalker]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #0)
> The GCLI helper buttons (Tilt cube, Scratchpad and Responsive View) should
> not be visible when the Developer Tools are launched in Remote mode. They
> don't work.
> 
> One possibility would be to put them in the global toolbar next to the
> command line.

Good spot.

We'd like to move the command line into the developer tools window, so they could work (this would require a remote-able gcli, or one that was hidden if the target was remote)

I think that in the short term we should remove the buttons if the target is remote.

Comment 2

[Rob Campbell [:rc] (:robcee)]

that wfm.

see also: https://github.com/joewalker/devtools-window/pull/311

Comment 3

[Joe Walker [:jwalker]]

This landed with the second landing of the devtools window

Comment 4

[Joe Walker [:jwalker]]

Correct, it's not landed. Will create patch.

Comment 5

[Joe Walker [:jwalker]]

Attachment: v1

r+ given here: https://github.com/joewalker/devtools-window/pull/311

Comment 6

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?rev=8a30e07815ff

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/a10926f5bc4e3aa57172e1d7315484ec4636e440
Merge pull request #1701 from brandonsavage/bug815246-crashes-by-adu

Bug915246 crashes by adu r=selenamarie