Closed Bug 815291 Opened 10 years ago Closed 10 years ago

Provide watch expressions context menus

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 20

People

(Reporter: vporof, Assigned: vporof)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file)

Similar to what we can do with the breakpoints, we need the following in the context of the watch expressions pane:
"Add watch expression"
"Delete watch expression"
"Delete all watch expressions"
Maybe also in the editor's context menu, for the currently selected text:
"Add as watch expression"
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P3
Attached patch v1Splinter Review
Easter egg: select some text in the editor and press cmd+shift+e :)
Attachment #685792 - Flags: review?(past)
Comment on attachment 685792 [details] [diff] [review]
v1

Review of attachment 685792 [details] [diff] [review]:
-----------------------------------------------------------------

How come you didn't add a menu item to remove the watch expression the user clicked on? Ran out of key modifiers?
Attachment #685792 - Flags: review?(past) → review+
(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 685792 [details] [diff] [review]
> v1
> 
> Review of attachment 685792 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> How come you didn't add a menu item to remove the watch expression the user
> clicked on? Ran out of key modifiers?

It *seemed* a bit redundant, since the close button is a few pixels away. That's not the case with "add" or "remove all".
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/1edb4b4b310a
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1edb4b4b310a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Can someone explain the string "Selection to watch expression"? It sounds strange to me and I don't really understand what it does.
(In reply to Francesco Lodolo [:flod] from comment #7)
> Can someone explain the string "Selection to watch expression"? It sounds
> strange to me and I don't really understand what it does.

It creates a new watch expression from the currently selected text in the source editor (the area in which the source text is displayed).
Thanks Victor, so an equivalent could be "Select expression to watch"?
(In reply to Francesco Lodolo [:flod] from comment #9)
> Thanks Victor, so an equivalent could be "Select expression to watch"?

That doesn't sound accurate to me. How about "Create watch expression from selection"?
> That doesn't sound accurate to me. How about "Create watch expression from
> selection"?

Thanks, much clearer, I didn't get the meaning at all.
Depends on: 918017
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.