815291 - Provide watch expressions context menus

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

Similar to what we can do with the breakpoints, we need the following in the context of the watch expressions pane:
"Add watch expression"
"Delete watch expression"
"Delete all watch expressions"
Maybe also in the editor's context menu, for the currently selected text:
"Add as watch expression"

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Easter egg: select some text in the editor and press cmd+shift+e :)

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 685792 [details] [diff] [review]
v1

Review of attachment 685792 [details] [diff] [review]:
-----------------------------------------------------------------

How come you didn't add a menu item to remove the watch expression the user clicked on? Ran out of key modifiers?

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 685792 [details] [diff] [review]
> v1
> 
> Review of attachment 685792 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> How come you didn't add a menu item to remove the watch expression the user
> clicked on? Ran out of key modifiers?

It *seemed* a bit redundant, since the close button is a few pixels away. That's not the case with "add" or "remove all".

Comment 4

[Victor Porof [:vporof][:vp]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=61373316b732

Comment 5

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/1edb4b4b310a

Comment 6

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/1edb4b4b310a

Comment 7

[Francesco Lodolo [:flod]]

Can someone explain the string "Selection to watch expression"? It sounds strange to me and I don't really understand what it does.

Comment 8

[Victor Porof [:vporof][:vp]]

(In reply to Francesco Lodolo [:flod] from comment #7)
> Can someone explain the string "Selection to watch expression"? It sounds
> strange to me and I don't really understand what it does.

It creates a new watch expression from the currently selected text in the source editor (the area in which the source text is displayed).

Comment 9

[Francesco Lodolo [:flod]]

Thanks Victor, so an equivalent could be "Select expression to watch"?

Comment 10

[Victor Porof [:vporof][:vp]]

(In reply to Francesco Lodolo [:flod] from comment #9)
> Thanks Victor, so an equivalent could be "Select expression to watch"?

That doesn't sound accurate to me. How about "Create watch expression from selection"?

Comment 11

[Francesco Lodolo [:flod]]

> That doesn't sound accurate to me. How about "Create watch expression from
> selection"?

Thanks, much clearer, I didn't get the meaning at all.