815317 - Toggle to have phone vibrate

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Michael:mtreese]

USER-SOUND-003	As a user I can toggle to have my phone vibrate when i receive notifications.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The easiest solution here is likely to do a short vibration on every notification which is put in the notification tray, and then have a setting which controls if we should vibrate or not.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Jonas Sicking (:sicking) from comment #1)
> The easiest solution here is likely to do a short vibration on every
> notification which is put in the notification tray, and then have a setting
> which controls if we should vibrate or not.

Agree. So let's put an check box about 'notification vibration' in settings app notification panel or sound panel.
Casey, the item in notification panel in settings is very poor now: only a 'show on lockscreen' item.
Where do you prefer?

Also c.c. lco

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Having a setting which drives this, and then have the system app honor that setting whenever we put a notification in the notification bar sounds good to me.

I'm not sure what UI we should use to drive this setting though. One option is to make the setting configurable using a simple checknbox in settings app. Another option is that the setting is set whenever the user lowers the volume to "mute". A third is to have some combination of the two.

A UX spec is needed

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

A mew settings called 'notifications.vibrate' living in the Notification section will be nice. Assigning Etienne since he already has some branches with notifications changes...

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/a1ba7afbbaafd81aa2914383f7d3e76df4ceccad

Comment 6

[Larissa Co [:lco]]

(In reply to Alive Kuo [:alive] from comment #2)
> (In reply to Jonas Sicking (:sicking) from comment #1)
> > The easiest solution here is likely to do a short vibration on every
> > notification which is put in the notification tray, and then have a setting
> > which controls if we should vibrate or not.
> 
> Agree. So let's put an check box about 'notification vibration' in settings
> app notification panel or sound panel.
> Casey, the item in notification panel in settings is very poor now: only a
> 'show on lockscreen' item.
> Where do you prefer?
> 
> Also c.c. lco

The reason why notifications settings is thin is because we will eventually allow users to select which apps are allowed to provide notifications on the lock screen.

Cyee and I will discuss today how to organize all the sound / vibration requirements for everything, so stay tuned :)

Comment 7

[Larissa Co [:lco]]

I need some clarification on this bug request. Is the use case that we want to be able to set vibration for notifications independently from phone calls?

The current sound settings (which I will revise shortly) has a single vibrate switch which controls both vibration for phone calls and notifications:
See pg. 2 of http://f.cl.ly/items/1f3I3C0741451I1S1F2g/Sound%20Settings%20concepts%20v1.pdf

Is this enough to satisfy the user need? I looked at both Android and IOS and I don't see any way to adjust vibration for notifications separate from vibration for phone calls. I'm not saying we *shouldn't* do it, but I'm increasingly leaning towards NOT placing it in the notification panel.

There are some design challenges to separating vibration for notifications and calls. I'm experimenting with a design right now, but I don't want to go down this rabbit hole if we are ok with having a single control for call and notification vibration.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think it's a UI decision if we want to have "vibration mode" be separate for incoming phone calls and incoming notifications. So you should feel free to make a call there yourself.

The dialer application could use the vibrate API and vibrate any time there's an incoming call. And it can make the decision to do so based on either the same setting as was added in this bug, or based on a separate setting.

In order to keep things simple, I'd say lets use the same setting since that means that we don't have to add more UI. But ultimately I believe it's a UX decision.

Comment 9

[Larissa Co [:lco]]

Ok, thanks for clarifying. I updated my sound spec basing the design on the decision to have one setting to control vibration for both incoming phone calls and notifications.

http://people.mozilla.com/~lco/FFOS/Sound/

This means that we should remove the vibration (and ring) switches from the Notifications Settings also. Sorry!

Comment 10

[mlevin]

Verified fixed on Unagi build 20130103070201. Tested SMS, Alarm and incoming calls. All did indeed vibrate.