Last Comment Bug 815340 - Fix some more nullptr abuse in comm-central
: Fix some more nullptr abuse in comm-central
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 20.0
Assigned To: Ian Neal
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-26 13:44 PST by Ian Neal
Modified: 2012-11-29 14:47 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed


Attachments
Use false instead of nullptr [Checked in: Comment 2] (2.66 KB, patch)
2012-11-26 13:44 PST, Ian Neal
mconley: review+
Details | Diff | Splinter Review

Description Ian Neal 2012-11-26 13:44:11 PST
Created attachment 685313 [details] [diff] [review]
Use false instead of nullptr [Checked in: Comment 2]

There are a few places in the mailnews code that uses a nullptr where it should be using a boolean. This patch fixes the errors that clang throws up.
error: implicit conversion of NULL constant to 'bool'
Comment 1 Mike Conley (:mconley) - (Needinfo me!) 2012-11-29 10:20:54 PST
Comment on attachment 685313 [details] [diff] [review]
Use false instead of nullptr [Checked in: Comment 2]

Review of attachment 685313 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - thanks Ian!

::: mailnews/imap/src/nsImapMailFolder.cpp
@@ +7990,1 @@
>                           false, 0, EmptyCString(), listener, 

While you're here, please strip off this trailing whitespace.
Comment 2 Ian Neal 2012-11-29 14:46:22 PST
Comment on attachment 685313 [details] [diff] [review]
Use false instead of nullptr [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/3eccd275a9c9

Note You need to log in before you can comment on or make changes to this bug.