The default bug view has changed. See this FAQ.

Fix some more nullptr abuse in comm-central

RESOLVED FIXED in Thunderbird 20.0

Status

MailNews Core
Backend
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
Thunderbird 20.0

SeaMonkey Tracking Flags

(seamonkey2.17 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 685313 [details] [diff] [review]
Use false instead of nullptr [Checked in: Comment 2]

There are a few places in the mailnews code that uses a nullptr where it should be using a boolean. This patch fixes the errors that clang throws up.
error: implicit conversion of NULL constant to 'bool'
Attachment #685313 - Flags: review?(mconley)
Comment on attachment 685313 [details] [diff] [review]
Use false instead of nullptr [Checked in: Comment 2]

Review of attachment 685313 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - thanks Ian!

::: mailnews/imap/src/nsImapMailFolder.cpp
@@ +7990,1 @@
>                           false, 0, EmptyCString(), listener, 

While you're here, please strip off this trailing whitespace.
Attachment #685313 - Flags: review?(mconley) → review+
(Assignee)

Comment 2

4 years ago
Comment on attachment 685313 [details] [diff] [review]
Use false instead of nullptr [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/3eccd275a9c9
Attachment #685313 - Attachment description: Use false instead of nullptr → Use false instead of nullptr [Checked in: Comment 2]
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-seamonkey2.17: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
You need to log in before you can comment on or make changes to this bug.