815367 - warning: extra ';' [-pedantic] in media/mtransport/test/

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

Now that bug 811118 enabled WebRTC unittests, I'm seeing instances of the same issue from bug 812278, in the unittests directory.  (MOZ_MTLOG_MODULE having an unnecessary trailing ";")

e.g.:
> media/mtransport/test/sctp_unittest.cpp:36:131: warning: extra ';' [-pedantic]
> media/mtransport/test/transport_unittests.cpp:41:131: warning: extra ';' [-pedantic]
and maybe others.

Filing this bug on fixing those.

Comment 1

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

I also get:
> media/mtransport/test/sctp_unittest.cpp:36:25: warning: ‘PRLogModuleInfo* getLogModule()’ defined but not used [-Wunused-function]

...indicating that MOZ_MTLOG_MODULE isn't used in that file, so rather than dropping the trailing semicolon from the line in that file, we can just remove the line entirely.

Comment 2

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

Attachment: fix

This fixes the issues described above, plus one trailing-semicolon-after-NS_IMPL_ISUPPORTS0 in another test file.

Comment 3

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/819dc69e095c

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/819dc69e095c