Open
Bug 815404
Opened 12 years ago
Updated 2 years ago
add annotation to prevent static IDL operations from generating functions with an nsISupports* global
Categories
(Core :: DOM: Core & HTML, defect, P5)
Core
DOM: Core & HTML
Tracking
()
NEW
People
(Reporter: heycam, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
24.40 KB,
patch
|
Details | Diff | Splinter Review |
Some static functions, like CSS.supports(), do not need access to the global object, so it ought to be possible to say (in Bindings.conf or in the IDL) that the nsISupports* global argument is not added.
Does it really matter? The compiler will optimize it out.
Comment 2•12 years ago
|
||
I'm not sure the compiler can in fact optimize out the binding end of this (the actual extraction of the global from the call information, etc).
Comment 3•12 years ago
|
||
This uses templates to detect if a function with the right signature exists, either with or without a globalobject. Because of the templates the error messages are a bit verbose if no function with the right signature exists. Not sure the complexity is worth it. There are some smaller things we should do if we don't take the whole thing (like have separate types for worker/non-worker globalobject).
Comment 4•12 years ago
|
||
Moved the part about the type of the global object to bug 816088.
Attachment #689430 -
Attachment is obsolete: true
Comment 5•6 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046
Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.
If you have questions, please contact :mdaly.
Priority: -- → P5
Assignee | ||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•