Improperly formatted strings in Fennec; results in startup crash

RESOLVED FIXED

Status

Mozilla Localizations
ja / Japanese
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bnicholson, Assigned: dynamis (Tomoya ASAI))

Tracking

unspecified
ARM
Android

Firefox Tracking Flags

(firefox18 fixed, firefox19+ fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Localization strings are improperly formatted, causing Fennec to crash. See https://bugzilla.mozilla.org/show_bug.cgi?id=775142#c4.

There's a fix on central that changes the message ID, but 18 and 19 still need their strings to be updated.

Comment 1

5 years ago
It's the cause of the top-one crasher in Firefox 19.0a2 for Android.
tracking-firefox19: --- → ?

Comment 2

5 years ago
Dynamis - assigning to you in hopes that you can help find a final owner for this bug.
Assignee: nobody → bugzilla
tracking-firefox19: ? → +

Comment 3

5 years ago
You need to replace in mobile/android/base/android_strings.dtd for Beta and Aurora:
<!ENTITY suggestions_prompt "&#037; で検索語句の候補を表示しますか?">
by
<!ENTITY suggestions_prompt "&#037;s で検索語句の候補を表示しますか?">
Tomoya - have you had a chance to look into this yet?  We're halfway through Aurora 19's cycle now and it would be great to get a fix verified.
Flags: needinfo?(bugzilla)

Comment 5

5 years ago
Rejected the most recent sign-off for 18, as this would otherwise show up there, too.

AKA, we'll need a fix for this on both beta and aurora.
Created attachment 690025 [details] [diff] [review]
fix for fennec18

Can I apply this same patch to Aurora?

Comment 7

5 years ago
Comment on attachment 690025 [details] [diff] [review]
fix for fennec18

Review of attachment 690025 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I think this should work on both beta and aurora.
Attachment #690025 - Flags: feedback+
Beta:
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/066c7401bfdc

Aurora:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/3b36bb7320bb

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-firefox18: affected → fixed
status-firefox19: affected → fixed
Flags: needinfo?(bugzilla)
Resolution: --- → FIXED

Comment 9

5 years ago
Thanks, taken the sign-off. Should be in next week's beta build.
You need to log in before you can comment on or make changes to this bug.