815423 - Improperly formatted strings in Fennec; results in startup crash

Status: RESOLVED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[Brian Nicholson (:bnicholson)]

Localization strings are improperly formatted, causing Fennec to crash. See https://bugzilla.mozilla.org/show_bug.cgi?id=775142#c4.

There's a fix on central that changes the message ID, but 18 and 19 still need their strings to be updated.

Comment 1

[Scoobidiver (away)]

It's the cause of the top-one crasher in Firefox 19.0a2 for Android.

Comment 2

[Alex Keybl [:akeybl]]

Dynamis - assigning to you in hopes that you can help find a final owner for this bug.

Comment 3

[Scoobidiver (away)]

You need to replace in mobile/android/base/android_strings.dtd for Beta and Aurora:
<!ENTITY suggestions_prompt "&#037; で検索語句の候補を表示しますか？">
by
<!ENTITY suggestions_prompt "&#037;s で検索語句の候補を表示しますか？">

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Tomoya - have you had a chance to look into this yet?  We're halfway through Aurora 19's cycle now and it would be great to get a fix verified.

Comment 5

[Axel Hecht [:Pike]]

Rejected the most recent sign-off for 18, as this would otherwise show up there, too.

AKA, we'll need a fix for this on both beta and aurora.

Comment 6

[Masahiko Imanaka [:marsf]]

Attachment: fix for fennec18

Can I apply this same patch to Aurora?

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 690025 [details] [diff] [review]
fix for fennec18

Review of attachment 690025 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I think this should work on both beta and aurora.

Comment 8

[Masahiko Imanaka [:marsf]]

Beta:
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/066c7401bfdc

Aurora:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/3b36bb7320bb

Comment 9

[Axel Hecht [:Pike]]

Thanks, taken the sign-off. Should be in next week's beta build.