Always inline JS_THIS

RESOLVED FIXED in mozilla20

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

unspecified
mozilla20
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

JS_THIS doesn't always get inlined.  And when it doesn't, at least gcc 4.4 32-bit generates an 8-byte memmove for the jsval copy constructor(!).  Needless to say, this is all very slow.
Created attachment 685417 [details] [diff] [review]
Always inline JS_THIS so that we don't run into performance issues if the compiler decides not to inline it.
Attachment #685417 - Flags: review?(luke)

Comment 2

6 years ago
Comment on attachment 685417 [details] [diff] [review]
Always inline JS_THIS so that we don't run into performance issues if the compiler decides not to inline it.

Review of attachment 685417 [details] [diff] [review]:
-----------------------------------------------------------------

Swiping.
Attachment #685417 - Flags: review?(luke) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/20c8c8762a0c
Flags: in-testsuite-
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [need review]
Target Milestone: --- → mozilla20

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/20c8c8762a0c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.