Closed
Bug 815460
Opened 13 years ago
Closed 13 years ago
Always inline JS_THIS
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
JS_THIS doesn't always get inlined. And when it doesn't, at least gcc 4.4 32-bit generates an 8-byte memmove for the jsval copy constructor(!). Needless to say, this is all very slow.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #685417 -
Flags: review?(luke)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 685417 [details] [diff] [review]
Always inline JS_THIS so that we don't run into performance issues if the compiler decides not to inline it.
Review of attachment 685417 [details] [diff] [review]:
-----------------------------------------------------------------
Swiping.
Attachment #685417 -
Flags: review?(luke) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Flags: in-testsuite-
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [need review]
Target Milestone: --- → mozilla20
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•