When editing attributes in the markup-view inplace-editor changes should be previewed live

NEW
Unassigned

Status

defect
P2
normal
7 years ago
7 months ago

People

(Reporter: rcampbell, Unassigned)

Tracking

(Blocks 3 bugs)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [polish-backlog][difficulty=medium], URL)

(Reporter)

Description

7 years ago
When editing a node in the Inspector's Markup View, the actual node doesn't get updated until hitting enter to close the editor. Other Inspectors (e.g., Firebug) do this immediately on keypress. ESC to close the editor should revert to the original value.
That's true for the Rule view too, right?
Related bug: bug 755797

Updated

7 years ago
Priority: -- → P2

Updated

7 years ago
Summary: Markup view should update onchange in its popup editor → [markup view] should update onchange in its popup editor
(Reporter)

Comment 3

7 years ago
(In reply to Paul Rouget [:paul] from comment #1)
> That's true for the Rule view too, right?

yes! :)
(In reply to Rob Campbell [:rc] (:robcee) from comment #3)
> (In reply to Paul Rouget [:paul] from comment #1)
> > That's true for the Rule view too, right?
> 
> yes! :)
Not true anymore, typing in the rule-view immediately affects the style of the corresponding element (live preview).
As for the markup-view, there's no live-preview though. I wonder whether we should have it for all attributes. I don't see a need to actually apply the changes as you type for any attribute except maybe for the style attribute (so it works like the rule-view).
It makes sense in the style attribute and maybe some table-related markup.  Is there a downside, do you think, to making this auto-apply?

Comment 6

5 years ago
I originally suggested this because SVG editing was so difficult. In SVG almost all attributes make visible changes and many would benefit from arrow-up/arrow-down in numeric values, path d-attributes especially.
Whiteboard: [devedition-40]
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [devedition-40] → [devedition-40][difficulty=medium]
Whiteboard: [devedition-40][difficulty=medium] → [polish-backlog][difficulty=medium]
I am wondering what's the difference between this bug and bug 1067318. I'd assume this one is for the inline editor, while the other one is for the 'Edit As HTML' editor. Is that correct? If so, a summary change and a test case should make this clearer.

Sebastian
Flags: needinfo?(pbrosset)
See Also: → 1067318
(In reply to Sebastian Zartner [:sebo] from comment #7)
> I am wondering what's the difference between this bug and bug 1067318. I'd
> assume this one is for the inline editor, while the other one is for the
> 'Edit As HTML' editor. Is that correct?
This is correct indeed, those are 2 separate bugs.

STR:
- open the inspector on this page
- double-click at the end of the opening <body> tag in order to start creating a new attribute
- type style="background:red"
--> Notice that the red background only gets applied when pressing ENTER, not as you type.

The same happens when editing existing attributes, STR:
- double-click on the style attribute you just created
- change red to blue
--> Notice, again, that the blue background only gets applied when pressing ENTER, not as you type.
Flags: needinfo?(pbrosset)
Summary: [markup view] should update onchange in its popup editor → When editing attributes in the markup-view inplace-editor changes should be previewed live
Whiteboard: [polish-backlog][difficulty=medium] → [polish-backlog][difficulty=medium][todo-mr]
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
See Also: → 1339618
Whiteboard: [polish-backlog][difficulty=medium][todo-mr] → [polish-backlog][difficulty=medium]

Updated

11 months ago
Product: Firefox → DevTools
Assignee: jdescottes → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.