Closed Bug 815475 Opened 9 years ago Closed 9 years ago

Upgrade to pdfjs 0.6.39 broke Firefox metro pdfjs viewing

Categories

(Firefox :: PDF Viewer, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: bbondy, Assigned: bbondy)

Details

(Whiteboard: [metro-it1][LOE:1][metro-mvp])

Attachments

(1 file)

Upgrade to pdfjs 0.6.39 broke Firefox metro pdfjs viewing.  This is because the metro browser has no integrated find bar.
Attached patch Patch v1Splinter Review
Attachment #685441 - Flags: review?(dtownsend+bugmail)
Whiteboard: [metro-it1][LOE:1][metro-mvp]
Brian, I think you'll want to patch the upstream pdf.js repo and submit a pull request there:

https://github.com/mozilla/pdf.js/blob/babd8df1769a82b1b65a9e394a68cf695ed179dd/extensions/firefox/components/PdfStreamConverter.js#L347
Was just about to do that, thanks saved me some time :)
Can we still push this to m-c or will we be doing another update to a newer version of pdfjs soon?
We need to update the version on m-c, yes. I'll file the bug for that once this is fixed upstream.
I think the pull request is already accepted to pdfjs
Attachment #685441 - Flags: review?(dtownsend+bugmail) → review+
https://hg.mozilla.org/mozilla-central/rev/b19684c7502a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.