815475 - Upgrade to pdfjs 0.6.39 broke Firefox metro pdfjs viewing

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Brian R. Bondy [:bbondy]]

Upgrade to pdfjs 0.6.39 broke Firefox metro pdfjs viewing.  This is because the metro browser has no integrated find bar.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1

Comment 2

[Matthew N. [:MattN]]

Brian, I think you'll want to patch the upstream pdf.js repo and submit a pull request there:

https://github.com/mozilla/pdf.js/blob/babd8df1769a82b1b65a9e394a68cf695ed179dd/extensions/firefox/components/PdfStreamConverter.js#L347

Comment 3

[Yury Delendik (:yury)]

Pull request opened at https://github.com/mozilla/pdf.js/pull/2413

Comment 4

[Brian R. Bondy [:bbondy]]

Was just about to do that, thanks saved me some time :)

Comment 5

[Brian R. Bondy [:bbondy]]

Can we still push this to m-c or will we be doing another update to a newer version of pdfjs soon?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

We need to update the version on m-c, yes. I'll file the bug for that once this is fixed upstream.

Comment 7

[Brian R. Bondy [:bbondy]]

I think the pull request is already accepted to pdfjs

Comment 8

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b19684c7502a

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b19684c7502a