815531 - splinter fails to display attachment 681995 correctly

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Splinter, defect)

Description

[:glob ✱]

splinter fails to display attachment 681995 [details] [diff] [review] correctly.
it only finds one file, instead of four.

Comment 1

[:glob ✱]

the problem here is the first hunk:

@@ -0,0 +1,8 @@
+#filter substitution
+@MOZ_APP_BASENAME@_@MOZ_APP_VERSION@ {
+global: JS_*;
+js_*;
+_Z[NTVK0-9]*JS*;
+_Z[NTVK0-9]*js*;
+};
+
--- a/mozilla/toolkit/library/Makefile.in	2012-11-07 11:08:34.000000000 -0500
+++ b/mozilla/toolkit/library/Makefile.in	2012-11-07 11:08:15.000000000 -0500
@@ -120,6 +120,13 @@
 ifeq (Linux,$(OS_ARCH))
 ifneq (Android,$(OS_TARGET))
 OS_LIBS += -lrt

splinter was looking for lines which start with either - or + to find the end of the hunk, and was skipping over the --- and +++ lines thinking they were part of the hunk.  from there things went downhill.

i updated the hunk regex to include a negative lookahead for ---, which should fix this.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/Splinter/web/splinter.js
Committed revision 8791.