815733 - No opening about:privatebrowsing when opening a new window in private-browsing

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Environment:
* Firefox Aurora 19, http://hg.mozilla.org/releases/mozilla-aurora/rev/4e0a8f234a6d
* Intel Mac OS X 10.8

STR:
1. Enter Private browsing mode.
2. Open a new window. (from menubar, clicking dock icon, or dock context-menu)

Result:
Firefox does not open about:privatebrowsing.
In private browing mode, Firefox open about:privatebrowing when open a new window. (bug 763468)  This is regression.

But if I have opened a new tab in the window, Firefox open about:privatebrowsing as new tab. This work is correctly.

Comment 1

[Josh Matthews [:jdm]]

I'm aware of this problem. I'm not actually certain that this is a regression, but I haven't tested FF 18 to confirm. To fix it, we'll need to add specific checks in nsBrowserContentHandler.js to set the default page to about:privatebrowsing. It's not a very pleasant solution.

Comment 2

[(no longer active)]

(In reply to comment #1)
> I'm aware of this problem. I'm not actually certain that this is a regression,
> but I haven't tested FF 18 to confirm. To fix it, we'll need to add specific
> checks in nsBrowserContentHandler.js to set the default page to
> about:privatebrowsing. It's not a very pleasant solution.

Doesn't your other patch fix all of these cases?  Or is it just a problem of about:pb not showing up (and the window actually being marked as private properly)?

Comment 3

[Josh Matthews [:jdm]]

The window is marked private; just the homepage is incorrect.

Comment 4

[(no longer active)]

I see.  It would be great if you can first test to make sure that this is indeed a regression.

Comment 5

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

I found this bug is reproduced on http://hg.mozilla.org/mozilla-central/rev/58a4e9501f7e, Nightly 20.

I apologize that my sporadic report is complicated.

Comment 6

[(no longer active)]

I'm still not very clear on whether this bug is actually a regression.  Can someone please try this on Firerfox 17?

Comment 7

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Ehsan Akhgari [:ehsan] from comment #6)
> I'm still not very clear on whether this bug is actually a regression.  Can
> someone please try this on Firerfox 17?

This is reproduced on Firefox 17.
Sorry. This is not a regression, is my misunderstanding.

Bt the way, the current behavior is not good, I think.
I propose again that Firefox should open about:privatebrowsing when opening a new window in private-browsing.
This propose is not only modal private-browsing but also per-window-private-browsing.

Comment 8

[(no longer active)]

(In reply to comment #7)
> (In reply to Ehsan Akhgari [:ehsan] from comment #6)
> > I'm still not very clear on whether this bug is actually a regression.  Can
> > someone please try this on Firerfox 17?
> 
> This is reproduced on Firefox 17.
> Sorry. This is not a regression, is my misunderstanding.

OK, good to know!

> Bt the way, the current behavior is not good, I think.
> I propose again that Firefox should open about:privatebrowsing when opening a
> new window in private-browsing.
> This propose is not only modal private-browsing but also
> per-window-private-browsing.

We already do that.