815793 - Use $(TAR) instead of hardcoding tar in toolkit/mozapps/installer/packager.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Landry Breuil (:gaston)]

+++ This bug was initially created as a clone of Bug #658956 +++

packager.mk started using gnu tar options in 18.0b1 (since bug #798450), --exclude is a gnu-only option, thus breaking packaging for OpenBSD (and probably NetBSD)

Let's fix it by replacing all hardcoded tar invocations by $(TAR). For consistency, one could replace all tar -xf - calls by $(UNPACK_TAR), but that might be bikeshedding :)

Comment 1

[Landry Breuil (:gaston)]

Attachment: Replace hardcoded tar invocations by $(TAR)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 798450
User impact if declined: packaging failure on BSD
Testing completed (on m-c, etc.): wip
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none

Comment 2

[Alex Keybl [:akeybl]]

Comment on attachment 685818 [details] [diff] [review]
Replace hardcoded tar invocations by $(TAR)

Please re-nominate once this has been reviewed and landed on m-c.

Comment 3

[Landry Breuil (:gaston)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/de95a2aa8a8b

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/de95a2aa8a8b