815829 - Add MEMORY_VSIZE to telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Nicholas Nethercote [inactive]]

MEMORY_VSIZE is easy to measure and could provide useful data in understanding whether Win64 builds would be helpful.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Add MEMORY_VSIZE to telemetry.

Simple patch.  I tested it via about:telemetry (which is now built-in!).

Comment 2

[Justin Lebar (not reading bugmail)]

Comment on attachment 686002 [details] [diff] [review]
Add MEMORY_VSIZE to telemetry.

Can you make the upper bound a bit bigger than 4GB?  For our 64-bit discussions I'd be curious to know how many people on 64-bit platforms have vsize > 4gb.

Also, I've concluded that it was probably a mistake to use 50 buckets in memory_resident.  (We can't change it now without messing up historical comparisons, which is why I haven't touched it.)  The telemetry front-end does a poor job of smoothing between buckets (for example when calculating averages), so the net result is that we have basically zero insight into what's happening between the buckets.  As a result, I'd be in favor of doubling or quadrupling the number of buckets here, to 100 or 200.

The downside of having so many buckets is that pings potentially get larger.  But I don't think that's a big deal.

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ec460e1bd87

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7ec460e1bd87