The default bug view has changed. See this FAQ.

Add MEMORY_VSIZE to telemetry

RESOLVED FIXED in mozilla20

Status

()

Toolkit
Telemetry
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla20
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
MEMORY_VSIZE is easy to measure and could provide useful data in understanding whether Win64 builds would be helpful.
(Assignee)

Comment 1

4 years ago
Created attachment 686002 [details] [diff] [review]
Add MEMORY_VSIZE to telemetry.

Simple patch.  I tested it via about:telemetry (which is now built-in!).
Attachment #686002 - Flags: review?(justin.lebar+bug)
Comment on attachment 686002 [details] [diff] [review]
Add MEMORY_VSIZE to telemetry.

Can you make the upper bound a bit bigger than 4GB?  For our 64-bit discussions I'd be curious to know how many people on 64-bit platforms have vsize > 4gb.

Also, I've concluded that it was probably a mistake to use 50 buckets in memory_resident.  (We can't change it now without messing up historical comparisons, which is why I haven't touched it.)  The telemetry front-end does a poor job of smoothing between buckets (for example when calculating averages), so the net result is that we have basically zero insight into what's happening between the buckets.  As a result, I'd be in favor of doubling or quadrupling the number of buckets here, to 100 or 200.

The downside of having so many buckets is that pings potentially get larger.  But I don't think that's a big deal.
Attachment #686002 - Flags: review?(justin.lebar+bug) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ec460e1bd87
https://hg.mozilla.org/mozilla-central/rev/7ec460e1bd87
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.