815905 - WebRTC on Android 2.2 builds crash due to missing OpenSLES backend

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Dan Mosedale (:dmosedale, :dmose)]

This is a result of the fact that we currently link directly with libOpenSLES on Android.  We need to switch to loading that dynamically, and do something with the symbols (turn them into weak symbols?) that the build wants from there.

Because automated builds and tests are currently on Android 2.2, this is needed before we can make --enable-webrtc the default on Android.

Comment 1

[Jason Smith [:jsmith]]

Don't think there's an explicit test needed here, as other crashtests probably will cover what's needed to be automated.

Comment 2

[Mike]

When will be WEBRTC mozRTCPeerConnection  be supported on android platform for development purposes?

Comment 3

[Gian-Carlo Pascutto [:gcp]]

It's possible to make a build form source now that has it. So if you are willing to compile from source, you can do it now. It won't be enabled on official builds until someone fixes this bug.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Another path to perhaps consider here is to see if we can't just compile and ship the Android OpenSLES lib with Firefox, and use that if the system one isn't available. This might be infeasible or it might be a quick win, perhaps worth checking time comes.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. dlopen OpenSLES libraries

Comment 6

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 2. Fall back to JNI Audio if OpenSLES fails.

Tested that this doesn't break 2.3+, can't test 2.2 for now due to other bugs. I believe this would allow us to extend WebRTC support to Android 2.2. How awesome is that?

Comment 7

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3fe83ef26e3
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc114c0cf8a7

Comment 8

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/a3fe83ef26e3
https://hg.mozilla.org/mozilla-central/rev/bc114c0cf8a7