Closed Bug 815905 Opened 7 years ago Closed 7 years ago

WebRTC on Android 2.2 builds crash due to missing OpenSLES backend

Categories

(Core :: WebRTC: Audio/Video, defect, P2, critical)

Product:
Core
Component:
WebRTC: Audio/Video
Platform:
ARM
Android
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23

People

(Reporter: dmose, Assigned: gcp)

References

(Blocks 1 open bug)

Details

(Keywords: crash, Whiteboard: [qa-automation-blocked][webrtc][blocking-webrtc-][android-webrtc+][qa-])

Attachments

(2 files)

Patch 1. dlopen OpenSLES libraries
12.21 KB, patch
jesup
: review+
Details | Diff | Splinter Review
Patch 2. Fall back to JNI Audio if OpenSLES fails.
11.81 KB, patch
jesup
: review+
Details | Diff | Splinter Review 
This is a result of the fact that we currently link directly with libOpenSLES on Android.  We need to switch to loading that dynamically, and do something with the symbols (turn them into weak symbols?) that the build wants from there.

Because automated builds and tests are currently on Android 2.2, this is needed before we can make --enable-webrtc the default on Android.
Priority: -- → P2
Summary: uses WebRTC on Android 2.2 builds crash than causing explicit failure → WebRTC on Android 2.2 builds crash instead of causing explicit failure of webrtc calls
Whiteboard: [automation-blocked][webrtc][blocking-webrtc-]
Severity: normal → critical
Keywords: crash
Don't think there's an explicit test needed here, as other crashtests probably will cover what's needed to be automated.
Flags: in-testsuite-
When will be WEBRTC mozRTCPeerConnection  be supported on android platform for development purposes?
It's possible to make a build form source now that has it. So if you are willing to compile from source, you can do it now. It won't be enabled on official builds until someone fixes this bug.
Another path to perhaps consider here is to see if we can't just compile and ship the Android OpenSLES lib with Firefox, and use that if the system one isn't available. This might be infeasible or it might be a quick win, perhaps worth checking time comes.
Blocks: 835716
Whiteboard: [automation-blocked][webrtc][blocking-webrtc-] → [automation-blocked][webrtc][blocking-webrtc-][android-webrtc+]
Whiteboard: [automation-blocked][webrtc][blocking-webrtc-][android-webrtc+] → [qa-automation-blocked][webrtc][blocking-webrtc-][android-webrtc+]
Summary: WebRTC on Android 2.2 builds crash instead of causing explicit failure of webrtc calls → WebRTC on Android 2.2 builds crash due to missing OpenSLES backend
Assignee: nobody → gpascutto
Attachment #736770 - Flags: review?(rjesup)
Tested that this doesn't break 2.3+, can't test 2.2 for now due to other bugs. I believe this would allow us to extend WebRTC support to Android 2.2. How awesome is that?
Attachment #736847 - Flags: review?(rjesup)
Attachment #736770 - Flags: review?(rjesup) → review+
Attachment #736847 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/a3fe83ef26e3
https://hg.mozilla.org/mozilla-central/rev/bc114c0cf8a7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Whiteboard: [qa-automation-blocked][webrtc][blocking-webrtc-][android-webrtc+] → [qa-automation-blocked][webrtc][blocking-webrtc-][android-webrtc+][qa-]
You need to log in before you can comment on or make changes to this bug.