Closed Bug 815906 Opened 9 years ago Closed 9 years ago

Add main thread assertions when marking things

Categories

(Core :: JavaScript Engine, defect)

Other Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: bhackett1024, Unassigned)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
It would be good to assert that we only try to mark objects from the runtime's main thread.  This is helpful both on general principle, and to diagnose crashes decoder is seeing that seem to indicate off thread Ion compilation is trying to mark things.
Attachment #685908 - Flags: review?(wmccloskey)
Comment on attachment 685908 [details] [diff] [review]
patch

It looks like assertValidThread doesn't need to be JS_FRIEND_API.
Attachment #685908 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/6f0c997ba776
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Blocks: 817635
You need to log in before you can comment on or make changes to this bug.