Add main thread assertions when marking things

RESOLVED FIXED in mozilla20

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bhackett, Unassigned)

Tracking

Other Branch
mozilla20
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 685908 [details] [diff] [review]
patch

It would be good to assert that we only try to mark objects from the runtime's main thread.  This is helpful both on general principle, and to diagnose crashes decoder is seeing that seem to indicate off thread Ion compilation is trying to mark things.
Attachment #685908 - Flags: review?(wmccloskey)
Comment on attachment 685908 [details] [diff] [review]
patch

It looks like assertValidThread doesn't need to be JS_FRIEND_API.
Attachment #685908 - Flags: review?(wmccloskey) → review+

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/6f0c997ba776
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
(Reporter)

Updated

6 years ago
Blocks: 817635
You need to log in before you can comment on or make changes to this bug.