815915 - Split out WebGLVertexAttribData into a separate header

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

After bug 801499 split WebGLBuffer and a few other things out of WebGLContext.h, let's continue with a small class: WebGLVertexAttribData.

So you want to create a new header, WebGLVertexAttribData.h. I *think* you won't need a cpp file for that.

WebGLVertexAttribData.h will need to include WebGLObjectModel.h at least for WebGLRefPtr. I *think* you can get away with just that header (and forward-declare class WebGLBuffer). However, if I'm wrong, just #include WebGLBuffer.h (and it will include WebGLObjectModel.h for you).

The trick with WebGLVertexAttribData is that you will also need to move the specializations of ImplCycleCollection{Unlink,Traverse} for it, at the bottom of WebGLContext.h, and they will need to stay outside of namespace mozilla.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Note: this one is a small one. I'm filing other bugs for bigger ones if you're after big game.

Comment 2

[Eric Wong (:ekw)]

Attachment: Patch

Also ran mochitests -

Results of "TEST_PATH=content/canvas make mochitest-chrome"
29 INFO Passed: 25
30 INFO Failed: 0
31 INFO Todo:   0

Results of "TEST_PATH=content/canvas make mochitest-plain"
13572 INFO Passed: 13034
13573 INFO Failed: 0
13574 INFO Todo:   116

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 686433 [details] [diff] [review]
Patch

Review of attachment 686433 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks!

There are plenty other WebGL splitting bugs if you're interested, and more to come once the already filed ones are done --- there is a lot of work to do in the area of refactoring the WebGL implementation.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Do you need me to land this for you?

Comment 5

[Eric Wong (:ekw)]

Yes, please land.  I don't have permissions.  I do want to work on the other WebGL splitting bugs, time permitting.

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04c1cc1cb18e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/04c1cc1cb18e