Split out WebGLVertexAttribData into a separate header

RESOLVED FIXED in mozilla20

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bjacob, Assigned: ekw)

Tracking

unspecified
mozilla20
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=bjacob][lang=c++] webgl-next)

Attachments

(1 attachment)

After bug 801499 split WebGLBuffer and a few other things out of WebGLContext.h, let's continue with a small class: WebGLVertexAttribData.

So you want to create a new header, WebGLVertexAttribData.h. I *think* you won't need a cpp file for that.

WebGLVertexAttribData.h will need to include WebGLObjectModel.h at least for WebGLRefPtr. I *think* you can get away with just that header (and forward-declare class WebGLBuffer). However, if I'm wrong, just #include WebGLBuffer.h (and it will include WebGLObjectModel.h for you).

The trick with WebGLVertexAttribData is that you will also need to move the specializations of ImplCycleCollection{Unlink,Traverse} for it, at the bottom of WebGLContext.h, and they will need to stay outside of namespace mozilla.
(Reporter)

Updated

5 years ago
Summary: Split out WebGLVertexAttribData into separate files → Split out WebGLVertexAttribData into a separate header
(Reporter)

Comment 1

5 years ago
Note: this one is a small one. I'm filing other bugs for bigger ones if you're after big game.
(Assignee)

Comment 2

5 years ago
Created attachment 686433 [details] [diff] [review]
Patch

Also ran mochitests -

Results of "TEST_PATH=content/canvas make mochitest-chrome"
29 INFO Passed: 25
30 INFO Failed: 0
31 INFO Todo:   0

Results of "TEST_PATH=content/canvas make mochitest-plain"
13572 INFO Passed: 13034
13573 INFO Failed: 0
13574 INFO Todo:   116
Assignee: nobody → ewong3
Status: NEW → ASSIGNED
Attachment #686433 - Flags: review?(bjacob)
(Reporter)

Comment 3

5 years ago
Comment on attachment 686433 [details] [diff] [review]
Patch

Review of attachment 686433 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks!

There are plenty other WebGL splitting bugs if you're interested, and more to come once the already filed ones are done --- there is a lot of work to do in the area of refactoring the WebGL implementation.
Attachment #686433 - Flags: review?(bjacob) → review+
(Reporter)

Comment 4

5 years ago
Do you need me to land this for you?
(Assignee)

Comment 5

5 years ago
Yes, please land.  I don't have permissions.  I do want to work on the other WebGL splitting bugs, time permitting.
https://hg.mozilla.org/mozilla-central/rev/04c1cc1cb18e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.