815945 - Gonk needs to implement nsLookAndFeel::GetPasswordCharacterImpl

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Currently the password character is the default "*", which is ugly. On Windows we use UNICODE_BLACK_CIRCLE_CHAR, which looks nice if B2G fonts have it. But I don't know what fonts we're installing in B2G.

Comment 1

[Makoto Kato [:m_kato]]

MozTT font doesn't have UNICODE_BLACK_CIRCLE_CHAR glyph.  But there is U+2022 (UNICODE_BULLET uses on Android framework and android's LookAndFeel).

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Let's use that then!

Comment 3

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 687694 [details] [diff] [review]
fix

My c++ skills is not that much that I can do review :) Redirecting to Michael Wu

Comment 5

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/51464a5e7a00

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/51464a5e7a00