Closed Bug 815945 Opened 7 years ago Closed 7 years ago

Gonk needs to implement nsLookAndFeel::GetPasswordCharacterImpl

Categories

(Core Graveyard :: Widget: Gonk, defect)

18 Branch
All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla20

People

(Reporter: roc, Assigned: m_kato)

Details

Attachments

(1 file)

Currently the password character is the default "*", which is ugly. On Windows we use UNICODE_BLACK_CIRCLE_CHAR, which looks nice if B2G fonts have it. But I don't know what fonts we're installing in B2G.
MozTT font doesn't have UNICODE_BLACK_CIRCLE_CHAR glyph.  But there is U+2022 (UNICODE_BULLET uses on Android framework and android's LookAndFeel).
Attached patch fixSplinter Review
Assignee: nobody → m_kato
Attachment #687694 - Flags: review?(21)
Comment on attachment 687694 [details] [diff] [review]
fix

My c++ skills is not that much that I can do review :) Redirecting to Michael Wu
Attachment #687694 - Flags: review?(21) → review?(mwu)
OS: Windows 7 → Gonk (Firefox OS)
Hardware: x86_64 → All
Attachment #687694 - Flags: review?(mwu) → review+
https://hg.mozilla.org/mozilla-central/rev/51464a5e7a00
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.