Click-to-Play: Port Bug 812562 (click-to-play blocklisted plugins: reshow urlbar notification as with normal click-to-play)

NEW
Unassigned

Status

defect
7 years ago
5 years ago

People

(Reporter: philip.chee, Unassigned)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

7 years ago
Two more changes to CTP just landed on Mozilla-central:

Bug 746374 - click-to-play: differentiate by plugin type

> Click-to-play needs to treat different plugins separately. For instance,
> using the notification bar to enable one plugin (e.g. flash) on a site will
> not enable other plugin types (e.g. java).

Bug 812562 - click-to-play blocklisted plugins: reshow urlbar notification as with normal click-to-play

> When navigating back, click-to-play events aren't re-fired*, so we manually
> check and see if we need to re-show the popup notification (albeit in the
> dismissed state, so we just see the icon in the urlbar). However, this code
> assumes if "plugins.click_to_play" is false, it doesn't need to do
> anything. With the advent of click-to-play blocklisting, this is no longer
> the case.
Porting those two bugs might also fix the current test failures (test12c, test18e), but not sure about that.
Posted patch Patch so farSplinter Review
Just leaving this here in case someone else wants to work on this. This patch ports both bugs, but the _setPermissionForPlugins and following parts from Bug 746374 are still missing. I'll probably start working on Bug 798278 (multiple plugins CTP) first as Bug 746374 changes code in that area, too.
Reporter

Updated

6 years ago
Duplicate of this bug: 838770
Reporter

Comment 4

6 years ago
Porting of Bug 746374 is now in SeaMonkey bug Bug 854867.
Component: General → Passwords & Permissions
Summary: Click-to-Play: Port Bug 746374 (click-to-play: differentiate by plugin type) and Bug 812562 (click-to-play blocklisted plugins: reshow urlbar notification as with normal click-to-play) → Click-to-Play: Port Bug 812562 (click-to-play blocklisted plugins: reshow urlbar notification as with normal click-to-play)
You need to log in before you can comment on or make changes to this bug.