815954 - Click-to-Play: Port Bug 812562 (click-to-play blocklisted plugins: reshow urlbar notification as with normal click-to-play)

Status: RESOLVED WONTFIX

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Philip Chee]

Two more changes to CTP just landed on Mozilla-central:

Bug 746374 - click-to-play: differentiate by plugin type

> Click-to-play needs to treat different plugins separately. For instance,
> using the notification bar to enable one plugin (e.g. flash) on a site will
> not enable other plugin types (e.g. java).

Bug 812562 - click-to-play blocklisted plugins: reshow urlbar notification as with normal click-to-play

> When navigating back, click-to-play events aren't re-fired*, so we manually
> check and see if we need to re-show the popup notification (albeit in the
> dismissed state, so we just see the icon in the urlbar). However, this code
> assumes if "plugins.click_to_play" is false, it doesn't need to do
> anything. With the advent of click-to-play blocklisting, this is no longer
> the case.

Comment 1

[Frank Wein [:mcsmurf]]

Porting those two bugs might also fix the current test failures (test12c, test18e), but not sure about that.

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch so far

Just leaving this here in case someone else wants to work on this. This patch ports both bugs, but the _setPermissionForPlugins and following parts from Bug 746374 are still missing. I'll probably start working on Bug 798278 (multiple plugins CTP) first as Bug 746374 changes code in that area, too.

Comment 4

[Philip Chee]

Porting of Bug 746374 is now in SeaMonkey bug Bug 854867.

Comment 5

[Frank-Rainer Grahl (:frg)]

click to play is dead with the removal of NPAPI plugin support.