816041 - HTML5 audio doesn't pause for short sounds

Status: RESOLVED INACTIVE

(Core :: Audio/Video: Playback, defect, P2)

Description

[Marcin]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.25 Safari/537.17

Steps to reproduce:

http://jsfiddle.net/LrC9n/1/ - simple (short) sounds player on element hover. After facing this bug, I've tried also creating multiple Audio instances instead of pausing and changing source of this one - it didn't help, because pause didn't occur. 


Actual results:

When the audio is too short, and there is less than 1 second to end of audio the pause doesn't occur at all (even though paused property is set to true), and the sounds are overlapping.


Expected results:

The currently played sound should pause at all times when called audio.pause() (like in webkit based browsers).

Comment 1

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/e899fed03195
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110710 Firefox/8.0a1 ID:20110712003921
Bad:
http://hg.mozilla.org/mozilla-central/rev/699ee4c1a495
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110712 Firefox/8.0a1 ID:20110712015625
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e899fed03195&tochange=699ee4c1a495

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/6c328da30bed
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110711 Firefox/8.0a1 ID:20110711194529
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/c8afe7ab83e7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110711 Firefox/8.0a1 ID:20110711224743
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6c328da30bed&tochange=c8afe7ab83e7
Suspected : Bug 592833

Comment 2

[Reuben Morais [:reuben]]

Marking as blocking gecko-games since this is a common use case in gamedev.

Comment 3

[Ric Hardacre]

I wrote a HTML5 drum machine emulator, here, http://thedecibelkid.com/?45 - works fine in chrome but this bug prevents it from working in firefox!

Comment 4

[Paul Adenot (:padenot)]

I'm not sure what problem you hear, I'm hearing the same output between Chromium stable and Firefox Nightly. If you could describe in more depth the problem you are experiencing, it would be great.

Comment 5

[Ric Hardacre]

try this, should hear 3 quick sounds then a pause. On my build i only hear two - first and third, with the bug killing off the middle one. http://thedecibelkid.com/?45#4z161z16zc30zc34zc32

Comment 6

[Ric Hardacre]

Basically if the sample is longer than the retrigger then firefox ignores it, insisting it has to play to the end before allowing you to restart from the beginning. Code is like this:

function play(a)
{
   a.pause(); 
   a.currentTime=0;
   a.play();
}

Comment 7

[Paul Adenot (:padenot)]

You should test using a nightly build [1]. I can't reproduce on my machine.

[1]: http://nightly.mozilla.org/

Comment 8

[ferongr]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130326 Firefox/22.0 ID:20130326030941 CSet: 456cb08f8509

I can reproduce just fine. It may be platform dependent.

Comment 9

[Ric Hardacre]

From a high level, if currentTime represents seconds then is there some kind of rounding issue where at some point in the pipeline? e.g. if the currentTime is actually at 0.3 seconds it's easy to see that that rounds down to 0, so maybe some code (in an effort not to waste cycles doing work that has already been done) is not seeking because it's "close enough"?

Comment 10

[Paul Adenot (:padenot)]

Ric,

No rounding happens when seeking.

The right way to do what you want to do to clone the node you want to play when you want to play it:

>  function play(element) {
>    element.cloneNode(false).play()
>  }

This is fast in Gecko (it has been fastpathed), and allows you to trigger a sample before the end of the same sample. This is a technique that has been use with success by a lot of video game developers.

Comment 11

[Ric Hardacre]

the correct way to play a sound from position zero is to clone it and play the clone? as opposed to just saying "go to position zero"...

Comment 12

[Paul Adenot (:padenot)]

Not saying that we don't have a bug, just saying what works. I've checked on other machines and I cannot repro on Linux, but can repro on Windows and MacOS. Not sure if it is because my Linux machine is way beefier that the two others.

Comment 13

[Ric Hardacre]

OK, that does work, but it appears (Win64) that the clones aren't being garbage collected as the memory usage of firefox keeps increasing (only page open, no other requests or resources loading)

Comment 14

[Chris Pearce [:cpearce (Not reading bugmail)]]

The GC should happen eventually, unless you're still storing references to the audio elements somewhere (like you have an event listener still attached for example).

You can force the audio element to release its decoder by removing the "src" attribute and then calling "load()". A good time to do this would be in the ended listener, i.e.:

audioElementClone.addEventListener("ended", function(e){e.target.removeAttribute("src"); e.target.load(); }, false);

Comment 15

[Ric Hardacre]

"Eventually?" I stopped watching it after it added 50MB in process explorer. No events, literally doing what padnot suggested above.

All this event attachment sounds like a lot of effort and maintenance when I already have an object there that I'd like to set to position zero.

Comment 16

[Yuan Xulei [:yxl] (Leave from May 18)]

Attachment: short_audio.html

I can reproduce this bug on both Window 8 and Ubuntu 13.10. I tested firefox 30, 36, and 37.0a1. All these 3 version firefox has this bug.

I made a page in the attachment file to test this bug. The page plays a 0.5 second wav file and pauses the audio at 0.1 second. It works well on Chrome, but fails to pause the audio on Firefox.

Step to reproduce:

* open the attachment html file and click the "Test" button.

Expected:

* The audio is paused at 0.1 second.

Actual:

* The UI of audio controls appears paused at 0.1 second, but sound keeps going.

Comment 17

[giakhanh00xxiao1989]

URL html5 games ex https://sites.google.com/site/unblockedgames667/color-valley

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:jimm, could you have a look please?
For more information, please visit auto_nag documentation.