816111 - Remove appdir dependency for application update tests in xpcshell tests

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Brian R. Bondy [:bbondy]]

Some toolkit/mozapps/update tests rely on having application specific preferences defined. One examples of this is app.update.service.enabled being set to true on Windows.

But not all apps that use toolkit/mozapps/ will have that set to true, so we should explicitly set it to true for the test that expects it to be set to true.

This matters more once metro lands because the ini file needs to specify the appdir for preferences.  Currently on elm we had to set it to browser, but I don't think that's right inside of toolkit.

Comment 1

[Brian R. Bondy [:bbondy]]

For reference default prefs should be set like this:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/test/chrome/utils.js#821

Comment 2

[Robert Strong (they/them - no direct email)]

(In reply to Brian R. Bondy [:bbondy] from comment #1)
> For reference default prefs should be set like this:
> http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/test/
> chrome/utils.js#821
user pref or default pref that needs tp be set for the test.

If there are prefs that should be set prior to running any tests (e.g. disabling app update checks and add-ons update checks so they don't run due to the interval to check expiring, etc.) you can set prefs for all tests as follows
http://mxr.mozilla.org/mozilla-central/source/testing/tps/tps/testrunner.py#57
http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/mozprofile/mozprofile/profile.py#227
etc.

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1

Turned out to be easier than I thought, the maintenance service pref was the only one causing problems locally.

Pushing this to try now though to be sure.  Will request review if it passes.

Comment 4

[Brian R. Bondy [:bbondy]]

I'll sync review comments if any to elm:
https://hg.mozilla.org/projects/elm/rev/dee809938d3d

Comment 5

[Brian R. Bondy [:bbondy]]

Comment on attachment 686411 [details] [diff] [review]
Patch v1

This review request is for m-c.

Ignore the xpcshell.ini changes though, that's only on elm and it was only done to get the xpcshell tests working temporarily.

Comment 6

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/52ef151bed33

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/52ef151bed33